You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/01/17 01:45:59 UTC
[jira] Created: (THRIFT-275) Remove deprecated classes from Ruby
library
Remove deprecated classes from Ruby library
-------------------------------------------
Key: THRIFT-275
URL: https://issues.apache.org/jira/browse/THRIFT-275
Project: Thrift
Issue Type: Improvement
Components: Library (Ruby)
Reporter: Bryan Duxbury
Priority: Minor
There are a lot of weirdly named files in the Ruby Thrift library in order for backwards compatibility to work. I think this is of dubious value, and is really confusing. The deprecation code is also very complicated.
I think we should just get rid of the backwards-compatibility deprecated stuff. We're pre-version 1.0, so better to get all the big changes in now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-275) Remove deprecated classes from Ruby
library
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688523#action_12688523 ]
Kevin Clark commented on THRIFT-275:
------------------------------------
Looks great, push it.
> Remove deprecated classes from Ruby library
> -------------------------------------------
>
> Key: THRIFT-275
> URL: https://issues.apache.org/jira/browse/THRIFT-275
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-275.patch
>
>
> There are a lot of weirdly named files in the Ruby Thrift library in order for backwards compatibility to work. I think this is of dubious value, and is really confusing. The deprecation code is also very complicated.
> I think we should just get rid of the backwards-compatibility deprecated stuff. We're pre-version 1.0, so better to get all the big changes in now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-275) Remove deprecated classes from Ruby
library
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670061#action_12670061 ]
Kevin Clark commented on THRIFT-275:
------------------------------------
I'm alright with this, as long as we well document the changes. Right now anyone pulling trunk would be getting the dep warnings, but those waiting for a new release would just see breakage.
> Remove deprecated classes from Ruby library
> -------------------------------------------
>
> Key: THRIFT-275
> URL: https://issues.apache.org/jira/browse/THRIFT-275
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Priority: Minor
> Fix For: 0.1
>
>
> There are a lot of weirdly named files in the Ruby Thrift library in order for backwards compatibility to work. I think this is of dubious value, and is really confusing. The deprecation code is also very complicated.
> I think we should just get rid of the backwards-compatibility deprecated stuff. We're pre-version 1.0, so better to get all the big changes in now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-275) Remove deprecated classes from Ruby
library
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-275:
---------------------------------
Attachment: thrift-275.patch
This patch removes all the deprecation stuff and the t*.rb classes that were only placeholders. In addition, I've changed the implementations of some "abstract" methods to throw NotImplementedError instead of returning nil, and fixed the test accordingly. Finally, I removed the no longer required borrow and consume methods from all the transport implementations that had them. (Borrow and consume have been supplanted by the thrift_native package.)
All the specs and unit test pass, so I think the job is done. It seems like the only documentation that needs to be made is to indicate that when you see
{code}no such file "thrift/thrift"{code}
you just change it to
{code}require "thrift"{code}
and your problems more or less go away. (You will have to replace the T with Thrift:: on some declarations, but that's pretty easy too.)
I'd love to have this reviewed and get it committed.
> Remove deprecated classes from Ruby library
> -------------------------------------------
>
> Key: THRIFT-275
> URL: https://issues.apache.org/jira/browse/THRIFT-275
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-275.patch
>
>
> There are a lot of weirdly named files in the Ruby Thrift library in order for backwards compatibility to work. I think this is of dubious value, and is really confusing. The deprecation code is also very complicated.
> I think we should just get rid of the backwards-compatibility deprecated stuff. We're pre-version 1.0, so better to get all the big changes in now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-275) Remove deprecated classes from Ruby
library
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-275:
---------------------------------
Fix Version/s: 0.1
> Remove deprecated classes from Ruby library
> -------------------------------------------
>
> Key: THRIFT-275
> URL: https://issues.apache.org/jira/browse/THRIFT-275
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Priority: Minor
> Fix For: 0.1
>
>
> There are a lot of weirdly named files in the Ruby Thrift library in order for backwards compatibility to work. I think this is of dubious value, and is really confusing. The deprecation code is also very complicated.
> I think we should just get rid of the backwards-compatibility deprecated stuff. We're pre-version 1.0, so better to get all the big changes in now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-275) Remove deprecated classes from Ruby
library
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-275:
------------------------------------
Assignee: Bryan Duxbury
> Remove deprecated classes from Ruby library
> -------------------------------------------
>
> Key: THRIFT-275
> URL: https://issues.apache.org/jira/browse/THRIFT-275
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.1
>
>
> There are a lot of weirdly named files in the Ruby Thrift library in order for backwards compatibility to work. I think this is of dubious value, and is really confusing. The deprecation code is also very complicated.
> I think we should just get rid of the backwards-compatibility deprecated stuff. We're pre-version 1.0, so better to get all the big changes in now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-275) Remove deprecated classes from Ruby
library
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-275.
----------------------------------
Resolution: Fixed
Committed. Thanks for the review!
> Remove deprecated classes from Ruby library
> -------------------------------------------
>
> Key: THRIFT-275
> URL: https://issues.apache.org/jira/browse/THRIFT-275
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-275.patch
>
>
> There are a lot of weirdly named files in the Ruby Thrift library in order for backwards compatibility to work. I think this is of dubious value, and is really confusing. The deprecation code is also very complicated.
> I think we should just get rid of the backwards-compatibility deprecated stuff. We're pre-version 1.0, so better to get all the big changes in now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-275) Remove deprecated classes from Ruby
library
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-275:
---------------------------------
Patch Info: [Patch Available]
> Remove deprecated classes from Ruby library
> -------------------------------------------
>
> Key: THRIFT-275
> URL: https://issues.apache.org/jira/browse/THRIFT-275
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.1
>
> Attachments: thrift-275.patch
>
>
> There are a lot of weirdly named files in the Ruby Thrift library in order for backwards compatibility to work. I think this is of dubious value, and is really confusing. The deprecation code is also very complicated.
> I think we should just get rid of the backwards-compatibility deprecated stuff. We're pre-version 1.0, so better to get all the big changes in now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.