You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/25 15:13:47 UTC

[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #1570: [Improve] [core] Using right exit codes instead of all of -1 and -2

asdf2014 opened a new pull request #1570:
URL: https://github.com/apache/incubator-seatunnel/pull/1570


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   This PR is using right exit codes instead of all of -1 and -2
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1570: [Improve] [core] Using right exit codes instead of all of -1 and -2

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1570:
URL: https://github.com/apache/incubator-seatunnel/pull/1570#issuecomment-1079171074


   @asdf2014 I remember that I have already submitted a similar PR. Although there is no problem with this kind of separate submission, I think that similar problems like this can be checked as a whole and submitted to a single PR, thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1570: [Improve] [core] Using right exit codes instead of all of -1 and -2

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1570:
URL: https://github.com/apache/incubator-seatunnel/pull/1570#issuecomment-1079177518


   @wuchunfu This contains all, you are welcome to help double check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org