You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/30 16:51:25 UTC
[jira] [Commented] (CB-10981) Cordova-lib should not bundle
cordova-common anymore
[ https://issues.apache.org/jira/browse/CB-10981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218079#comment-15218079 ]
ASF GitHub Bot commented on CB-10981:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/419
CB-10981 Remove cordova-common from bundled dependencies
Since cordova-common has been released to NPM we do not need to bundle it into cordova-lib release packages. See [CB-10981](https://issues.apache.org/jira/browse/CB-10981)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10981
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/419.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #419
----
commit bf32ccc46c91ac8fdac5ef177be9be22f2bbf891
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-03-30T14:44:33Z
CB-10981 Remove cordova-common from bundled dependencies
----
> Cordova-lib should not bundle cordova-common anymore
> ----------------------------------------------------
>
> Key: CB-10981
> URL: https://issues.apache.org/jira/browse/CB-10981
> Project: Apache Cordova
> Issue Type: Task
> Components: CordovaLib
> Affects Versions: 6.1.1
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> Cordova-lib specifies cordova-common as a bundled dependency. This is something that was necessary before cordova-common had been published to NPM. At this moment this is unnecessary and causes increased package size and potential problems with published packages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org