[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #7153: Spark: Support loading function via FunctionCatalog in SparkSessionCatalog

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #7153:
URL: https://github.com/apache/iceberg/pull/7153#discussion_r1145018303


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java:
##########
@@ -352,4 +355,16 @@ public Catalog icebergCatalog() {
         "Cannot return underlying Iceberg Catalog, wrapped catalog does not contain an Iceberg Catalog");
     return ((HasIcebergCatalog) icebergCatalog).icebergCatalog();
   }
+
+  @Override
+  public UnboundFunction loadFunction(Identifier ident) throws NoSuchFunctionException {
+    try {
+      return super.loadFunction(ident);
+    } catch (NoSuchFunctionException e) {
+      if (getSessionCatalog() instanceof FunctionCatalog) {

Review Comment:
   Yeah my main thought here is can this guard ever be false, I don't think it can but I don't have an issue with keeping the check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org