[jira] [Commented] (MESOS-5911) Webui redirection to leader in browser does not work

["Yan Xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394633#comment-15394633 ] 

Yan Xu commented on MESOS-5911:
-------------------------------

Don't know for sure but looks like we just need to add the header in the response to allow the redirect?

{code}
  explicit TemporaryRedirect(const std::string& url)
    : Response(Status::TEMPORARY_REDIRECT)
  {
    headers["Location"] = url;
+    headers["Access-Control-Allow-Origin"] = "*";
  }
{code}

However this wouldn't be a complete fix as it seems like we can now point the browser to any follower and it should work given the redirects of /state and other endpoints. We should probably tidy up the javascript code to handle this.

> Webui redirection to leader in browser does not work
> ----------------------------------------------------
>
>                 Key: MESOS-5911
>                 URL: https://issues.apache.org/jira/browse/MESOS-5911
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Jacob Janco
>              Labels: webui
>
> We deployed 1.0.0-rc4 in a small test cluster with 3 masters/5 agents. Redirection to master curling for state.json returned the expected 307, however, in browser (chrome/safari/firefox), redirection failed with: 
> {code}
> XMLHttpRequest cannot load <master_url_1>:5050/master/state. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin '<master_url_2>:5050' is therefore not allowed access.
> {code}
> This is the patch that introduced the redirect on /state (and HTTP calls): https://reviews.apache.org/r/34646
> The issue is that before this change, the server side does not redirect, the web UI controller.js decides from the content of the state.json which leader to redirect and then invoke redirection itself. Browsers allow this but not the server side initiated redirect without 'Access-Control-Allow-Origin' header?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)