You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2015/12/11 18:32:19 UTC
[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1104
Brooklyn properties files may be symlinks
The `?00` permissions check is enforced on the link's target rather than the link itself.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn feature/properties-symlink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1104
----
commit 443fa4be57fd6c0b1ff381c530b71537bc0ec194
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2015-12-11T17:31:52Z
Brooklyn properties files may be symlinks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1104#discussion_r47897382
--- Diff: usage/launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynLauncher.java ---
@@ -710,32 +719,42 @@ private void initManagementContext() {
}
}
- private boolean fileExists(String file) {
- return new File(Os.tidyPath(file)).exists();
+ /**
+ * @return The canonical path of the argument.
+ */
+ private File resolveSymbolicLink(File f) {
+ File f2 = f;
+ try {
+ f2 = f.getCanonicalFile();
+ if (Files.isSymbolicLink(f.toPath())) {
+ LOG.debug("Resolved symbolic link: {} -> {}", f, f2);
+ }
+ } catch (IOException e) {
+ LOG.warn("Could not determine canonical name of global properties file", e);
--- End diff --
Perhaps change log message to not say `global properties file`, as this method is more generic (even if currently only called in that one case)?
How about `Could not determine canonical path of file "+f, e`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1104#issuecomment-165434366
@sjcorbett Looks good - one very minor comment about an improvement to a log message. Good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...
Posted by sjcorbett <gi...@git.apache.org>.
GitHub user sjcorbett reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1104
Brooklyn properties files may be symlinks
The `?00` permissions check is enforced on the link's target rather than the link itself.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn feature/properties-symlink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1104
----
commit 443fa4be57fd6c0b1ff381c530b71537bc0ec194
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2015-12-11T17:31:52Z
Brooklyn properties files may be symlinks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1104#issuecomment-164138585
`Build timed out (after 40 minutes). Marking the build as aborted.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Brooklyn properties files may be ...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1104#issuecomment-165435426
agree re log message, i've applied that and merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---