You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/09 15:58:20 UTC
[GitHub] [flink] yanghua opened a new pull request #10819:
[hotfix][documentation] Fix wrong time semantics description
yanghua opened a new pull request #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819
## What is the purpose of the change
*This pull request fixes wrong time semantics description*
## Brief change log
- *Fix wrong time semantics description*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10819:
[hotfix][documentation] Fix wrong time semantics description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819#issuecomment-572645842
<!--
Meta data
Hash:a0b9ba16a555910a656710c572c387111dbb1a5a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143764711 TriggerType:PUSH TriggerID:a0b9ba16a555910a656710c572c387111dbb1a5a
Hash:a0b9ba16a555910a656710c572c387111dbb1a5a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4239 TriggerType:PUSH TriggerID:a0b9ba16a555910a656710c572c387111dbb1a5a
-->
## CI report:
* a0b9ba16a555910a656710c572c387111dbb1a5a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143764711) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4239)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on issue #10819: [hotfix][documentation]
Fix wrong time semantics description
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819#issuecomment-572626035
cc @zentol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #10819: [hotfix][documentation]
Fix wrong time semantics description
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819#issuecomment-582842432
Good catch! I'm merging 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10819:
[hotfix][documentation] Fix wrong time semantics description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819#issuecomment-572645842
<!--
Meta data
Hash:a0b9ba16a555910a656710c572c387111dbb1a5a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143764711 TriggerType:PUSH TriggerID:a0b9ba16a555910a656710c572c387111dbb1a5a
Hash:a0b9ba16a555910a656710c572c387111dbb1a5a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4239 TriggerType:PUSH TriggerID:a0b9ba16a555910a656710c572c387111dbb1a5a
-->
## CI report:
* a0b9ba16a555910a656710c572c387111dbb1a5a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143764711) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4239)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha merged pull request #10819:
[hotfix][documentation] Fix wrong time semantics description
Posted by GitBox <gi...@apache.org>.
aljoscha merged pull request #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10819: [hotfix][documentation]
Fix wrong time semantics description
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819#issuecomment-572645842
<!--
Meta data
Hash:a0b9ba16a555910a656710c572c387111dbb1a5a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a0b9ba16a555910a656710c572c387111dbb1a5a
-->
## CI report:
* a0b9ba16a555910a656710c572c387111dbb1a5a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10819:
[hotfix][documentation] Fix wrong time semantics description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819#issuecomment-572645842
<!--
Meta data
Hash:a0b9ba16a555910a656710c572c387111dbb1a5a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143764711 TriggerType:PUSH TriggerID:a0b9ba16a555910a656710c572c387111dbb1a5a
Hash:a0b9ba16a555910a656710c572c387111dbb1a5a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4239 TriggerType:PUSH TriggerID:a0b9ba16a555910a656710c572c387111dbb1a5a
-->
## CI report:
* a0b9ba16a555910a656710c572c387111dbb1a5a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143764711) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4239)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10819: [hotfix][documentation]
Fix wrong time semantics description
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819#issuecomment-572627539
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a0b9ba16a555910a656710c572c387111dbb1a5a (Thu Jan 09 16:02:36 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on issue #10819: [hotfix][documentation]
Fix wrong time semantics description
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #10819: [hotfix][documentation] Fix wrong time semantics description
URL: https://github.com/apache/flink/pull/10819#issuecomment-582708946
cc @aljoscha if you have time to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services