You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2017/12/12 19:59:34 UTC

[whimsy] branch master updated: switch to component instance properties

This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 1054148  switch to component instance properties
1054148 is described below

commit 10541487a05577cacb5f55aeb244cf02268d9043
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Tue Dec 12 14:59:23 2017 -0500

    switch to component instance properties
---
 www/secretary/workbench/views/forms/icla2.js.rb | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/www/secretary/workbench/views/forms/icla2.js.rb b/www/secretary/workbench/views/forms/icla2.js.rb
index 88e64ad..089e70a 100644
--- a/www/secretary/workbench/views/forms/icla2.js.rb
+++ b/www/secretary/workbench/views/forms/icla2.js.rb
@@ -4,6 +4,7 @@ class ICLA2 < Vue
     @checked = nil
     @submitted = false
     @search = ''
+    @iclas = []
   end
 
   def render
@@ -18,10 +19,10 @@ class ICLA2 < Vue
       end
     end
 
-    if @search.length >= 3
+    if @search.length >= 3 and not @iclas.empty?
       search = @search.downcase().split(' ')
       _ul.icla_search do
-        ICLA2.iclas.each do |icla|
+        @iclas.each do |icla|
           if
             search.all? {|part|
               icla.id.include? part or
@@ -102,7 +103,7 @@ class ICLA2 < Vue
   # on initial display, default various fields based on headers, and update
   # state 
   def mounted()
-    if ICLA2.iclas
+    if not @iclas.empty?
       @disabled = false
     else
       @disabled = true
@@ -114,7 +115,7 @@ class ICLA2 < Vue
       }
       fetch('../../iclas.json', args).then do |response|
         response.json().then do |json|
-          ICLA2.iclas = json
+          @iclas = json
           @disabled = true
         end
       end

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].