You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Apaar Trivedi <at...@bluefishgroup.com> on 2008/03/18 21:08:11 UTC

parameter needed in maven-eclipse-plugin

Hell,
 
We need one thing parameterized on the EclipseToMavenMojo.java in the
maven-eclipse-plugin which should be parameterized anyway.  In the call
to osgiVersionToMavenVersion, it only allows 'false' to be passed in for
the 'strip qualifier' parameter.

While the make-artifacts (which extends to-maven) target allows you to
strip the qualifier, this is not a parameter that can be used in the
to-maven target.  This is a problem because using 'to-maven' provides
artifacts with the proper names but the dependecies do not resolve due
to the qualifiers on the versions.  While make-artifacts provides
dependecies that resolve but the naming convention of the groupId's and
artifactId's is incorrect.  
 
Just a parameter -DstripQualifer that gets passed in to the call to 
      osgiVersionToMavenVersion( String version, String forcedQualifier,
boolean stripQualifier )
would be perfect.
 
Can I add this as a parameter and get this checked in or can someone do
it for me?  Aside from not providing proper naming conventions,
make-artifacts is deprecated.
 
Thanks for any help
 
Apaar Trivedi
O: (512) 469-9300 x 128
Blue Fish Development Group
http://www.bluefishgroup.com <http://www.bluefishgroup.com/> 
Blue Fish is Hiring! Check out www.bluefishgroup.com/careers
<http://www.bluefishgroup.com/careers> 
 

RE: parameter needed in maven-eclipse-plugin

Posted by Apaar Trivedi <at...@bluefishgroup.com>.
Unfortunately the make-artifacts goal does not do the same, it does not
name the artifact id's correctly and does not setup the heirarchy in the
repository correctly, which is why it is deprecated I believe. \

I have responded to the issue and will maintain the rest of my responses
to the issue.  Thank you for the fast response!

Apaar Trivedi



-----Original Message-----
From: carlossg@gmail.com [mailto:carlossg@gmail.com] On Behalf Of Carlos
Sanchez
Sent: Tuesday, March 18, 2008 5:59 PM
To: Maven Developers List
Subject: Re: parameter needed in maven-eclipse-plugin

i have answered to the issue, included here for reference. If you dont
like the way the to-maven goal works you need to use the make-artifacts
goal, it should do the same but allowing customization

The qualifier is an important part of the version, it's not the same
3.3.0.x than 3.3.0.y so if Eclipse releases both versions we are not the
people to strip it

You can use dependencyManagement section to explicitly set the versions
from Maven 2.0.9+ i've given a presentation at EclipseCON talking about
this and other problems, will post them soon
http://www.jroller.com/carlossg/entry/letters_from_eclipsecon


On Tue, Mar 18, 2008 at 3:52 PM, Apaar Trivedi
<at...@bluefishgroup.com> wrote:
> Thank you, I have submitted an issue with a patch.
>
>  http://jira.codehaus.org/browse/MECLIPSE-405
>
>  Thanks again,
>
> Apaar
>
>
>  -----Original Message-----
>  From: Arnaud HERITIER [mailto:aheritier@gmail.com]
>
>
> Sent: Tuesday, March 18, 2008 5:30 PM
>  To: Maven Developers List
>  Subject: Re: parameter needed in maven-eclipse-plugin
>
>  You can open an issue and attach your patch.
>  We see with carlos if your change seems to be interesting to apply (I

> think but I'm not an expert).
>
>  On Tue, Mar 18, 2008 at 11:02 PM, Apaar Trivedi  
> <at...@bluefishgroup.com> wrote:
>  > We have modified our copy locally and verified that what I am  > 
> describing  can be parameterized and it works.
>  >
>  >  I can provide a patch for review if that is desired, or any 
> feedback
>
>  > from Carlos or Brian would also be helpful.
>  >
>  >  Thanks!
>  >  Apaar
>  >
>  >
>  >
>  >
>  >
>  >  -----Original Message-----
>  >  From: Arnaud HERITIER [mailto:aheritier@gmail.com]  >  Sent: 
> Tuesday, March 18, 2008 4:59 PM  >  To: Maven Developers List  >  
> Subject: Re: parameter needed in maven-eclipse-plugin  >  >  Perhaps 
> Brian or Carlos could have an opinion about it (I think one  > of  
> them added it).
>  >  I didn't develop it and never played with this goal, thus I have 
> no  > idea  about it.
>  >
>  >  Arnaud
>  >
>  >  On Tue, Mar 18, 2008 at 9:08 PM, Apaar Trivedi  > 
> <at...@bluefishgroup.com> wrote:
>  >  > Hell,
>  >  >
>  >  >  We need one thing parameterized on the EclipseToMavenMojo.java 
> in  > the  >  >  > maven-eclipse-plugin which should be parameterized 
> anyway.  In the
>
>  > > call  to osgiVersionToMavenVersion, it only allows 'false' to be

> >  > passed in for  the 'strip qualifier' parameter.
>  >  >
>  >  >  While the make-artifacts (which extends to-maven) target allows

> > you  > to  strip the qualifier, this is not a parameter that can be

> > used in  > the  to-maven target.  This is a problem because using  
> 'to-maven'
>  >  > provides  artifacts with the proper names but the dependecies do

> > not  > resolve due  to the qualifiers on the versions.  While  > 
> make-artifacts  > provides  dependecies that resolve but the naming  >

> convention of the  > groupId's and  artifactId's is incorrect.
>  >  >
>  >  >  Just a parameter -DstripQualifer that gets passed in to the 
> call  to
>  >  >       osgiVersionToMavenVersion( String version, String
>  >  > forcedQualifier,  boolean stripQualifier )  would be perfect.
>  >  >
>  >  >  Can I add this as a parameter and get this checked in or can  >

> someone  > do  it for me?  Aside from not providing proper naming  > 
> conventions,  > make-artifacts is deprecated.
>  >  >
>  >  >  Thanks for any help
>  >  >
>  >  >  Apaar Trivedi
>  >  >  O: (512) 469-9300 x 128
>  >  >  Blue Fish Development Group
>  >  >  http://www.bluefishgroup.com <http://www.bluefishgroup.com/>  
> Blue
>
>  > > Fish is Hiring! Check out www.bluefishgroup.com/careers  >  > 
> <http://www.bluefishgroup.com/careers>
>  >  >
>  >  >
>  >
>  >
>  >
>  >  --
>  >  ..........................................................
>  >  Arnaud HERITIER
>  >  ..........................................................
>  >  OCTO Technology - aheritier AT octo DOT com www.octo.com |  > 
> blog.octo.com  
> ..........................................................
>  >  ASF - aheritier AT apache DOT org
>  >  www.apache.org | maven.apache.org
>  >  ...........................................................
>  >
>  >  
> ---------------------------------------------------------------------
>  >  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For  > 
> additional  commands, e-mail: dev-help@maven.apache.org  >  >  >  
> ---------------------------------------------------------------------
>  >  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org  For  > 
> additional commands, e-mail: dev-help@maven.apache.org  >  >
>
>
>
>  --
>  ..........................................................
>  Arnaud HERITIER
>  ..........................................................
>  OCTO Technology - aheritier AT octo DOT com www.octo.com | 
> blog.octo.com
..........................................................
>  ASF - aheritier AT apache DOT org
>  www.apache.org | maven.apache.org
>  ...........................................................
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For 
> additional  commands, e-mail: dev-help@maven.apache.org
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org  For 
> additional commands, e-mail: dev-help@maven.apache.org
>
>



--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
 -- The Princess Bride

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional
commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: parameter needed in maven-eclipse-plugin

Posted by Carlos Sanchez <ca...@apache.org>.
i have answered to the issue, included here for reference. If you dont
like the way the to-maven goal works you need to use the
make-artifacts goal, it should do the same but allowing customization

The qualifier is an important part of the version, it's not the same
3.3.0.x than 3.3.0.y so if Eclipse releases both versions we are not
the people to strip it

You can use dependencyManagement section to explicitly set the
versions from Maven 2.0.9+
i've given a presentation at EclipseCON talking about this and other
problems, will post them soon
http://www.jroller.com/carlossg/entry/letters_from_eclipsecon


On Tue, Mar 18, 2008 at 3:52 PM, Apaar Trivedi
<at...@bluefishgroup.com> wrote:
> Thank you, I have submitted an issue with a patch.
>
>  http://jira.codehaus.org/browse/MECLIPSE-405
>
>  Thanks again,
>
> Apaar
>
>
>  -----Original Message-----
>  From: Arnaud HERITIER [mailto:aheritier@gmail.com]
>
>
> Sent: Tuesday, March 18, 2008 5:30 PM
>  To: Maven Developers List
>  Subject: Re: parameter needed in maven-eclipse-plugin
>
>  You can open an issue and attach your patch.
>  We see with carlos if your change seems to be interesting to apply (I
>  think but I'm not an expert).
>
>  On Tue, Mar 18, 2008 at 11:02 PM, Apaar Trivedi
>  <at...@bluefishgroup.com> wrote:
>  > We have modified our copy locally and verified that what I am
>  > describing  can be parameterized and it works.
>  >
>  >  I can provide a patch for review if that is desired, or any feedback
>
>  > from Carlos or Brian would also be helpful.
>  >
>  >  Thanks!
>  >  Apaar
>  >
>  >
>  >
>  >
>  >
>  >  -----Original Message-----
>  >  From: Arnaud HERITIER [mailto:aheritier@gmail.com]
>  >  Sent: Tuesday, March 18, 2008 4:59 PM
>  >  To: Maven Developers List
>  >  Subject: Re: parameter needed in maven-eclipse-plugin
>  >
>  >  Perhaps Brian or Carlos could have an opinion about it (I think one
>  > of  them added it).
>  >  I didn't develop it and never played with this goal, thus I have no
>  > idea  about it.
>  >
>  >  Arnaud
>  >
>  >  On Tue, Mar 18, 2008 at 9:08 PM, Apaar Trivedi
>  > <at...@bluefishgroup.com> wrote:
>  >  > Hell,
>  >  >
>  >  >  We need one thing parameterized on the EclipseToMavenMojo.java in
>  > the
>  >
>  >  > maven-eclipse-plugin which should be parameterized anyway.  In the
>
>  > > call  to osgiVersionToMavenVersion, it only allows 'false' to be  >
>  > passed in for  the 'strip qualifier' parameter.
>  >  >
>  >  >  While the make-artifacts (which extends to-maven) target allows
>  > you  > to  strip the qualifier, this is not a parameter that can be
>  > used in  > the  to-maven target.  This is a problem because using
>  'to-maven'
>  >  > provides  artifacts with the proper names but the dependecies do
>  > not  > resolve due  to the qualifiers on the versions.  While
>  > make-artifacts  > provides  dependecies that resolve but the naming
>  > convention of the  > groupId's and  artifactId's is incorrect.
>  >  >
>  >  >  Just a parameter -DstripQualifer that gets passed in to the call
>  to
>  >  >       osgiVersionToMavenVersion( String version, String
>  >  > forcedQualifier,  boolean stripQualifier )  would be perfect.
>  >  >
>  >  >  Can I add this as a parameter and get this checked in or can
>  > someone  > do  it for me?  Aside from not providing proper naming
>  > conventions,  > make-artifacts is deprecated.
>  >  >
>  >  >  Thanks for any help
>  >  >
>  >  >  Apaar Trivedi
>  >  >  O: (512) 469-9300 x 128
>  >  >  Blue Fish Development Group
>  >  >  http://www.bluefishgroup.com <http://www.bluefishgroup.com/>  Blue
>
>  > > Fish is Hiring! Check out www.bluefishgroup.com/careers  >
>  > <http://www.bluefishgroup.com/careers>
>  >  >
>  >  >
>  >
>  >
>  >
>  >  --
>  >  ..........................................................
>  >  Arnaud HERITIER
>  >  ..........................................................
>  >  OCTO Technology - aheritier AT octo DOT com www.octo.com |
>  > blog.octo.com
>  ..........................................................
>  >  ASF - aheritier AT apache DOT org
>  >  www.apache.org | maven.apache.org
>  >  ...........................................................
>  >
>  >  ---------------------------------------------------------------------
>  >  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For
>  > additional  commands, e-mail: dev-help@maven.apache.org
>  >
>  >
>  >  ---------------------------------------------------------------------
>  >  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org  For
>  > additional commands, e-mail: dev-help@maven.apache.org
>  >
>  >
>
>
>
>  --
>  ..........................................................
>  Arnaud HERITIER
>  ..........................................................
>  OCTO Technology - aheritier AT octo DOT com www.octo.com | blog.octo.com
>  ..........................................................
>  ASF - aheritier AT apache DOT org
>  www.apache.org | maven.apache.org
>  ...........................................................
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional
>  commands, e-mail: dev-help@maven.apache.org
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>  For additional commands, e-mail: dev-help@maven.apache.org
>
>



-- 
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
 -- The Princess Bride

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: parameter needed in maven-eclipse-plugin

Posted by Apaar Trivedi <at...@bluefishgroup.com>.
Thank you, I have submitted an issue with a patch.

http://jira.codehaus.org/browse/MECLIPSE-405 

Thanks again,
Apaar


-----Original Message-----
From: Arnaud HERITIER [mailto:aheritier@gmail.com] 
Sent: Tuesday, March 18, 2008 5:30 PM
To: Maven Developers List
Subject: Re: parameter needed in maven-eclipse-plugin

You can open an issue and attach your patch.
We see with carlos if your change seems to be interesting to apply (I
think but I'm not an expert).

On Tue, Mar 18, 2008 at 11:02 PM, Apaar Trivedi
<at...@bluefishgroup.com> wrote:
> We have modified our copy locally and verified that what I am 
> describing  can be parameterized and it works.
>
>  I can provide a patch for review if that is desired, or any feedback

> from Carlos or Brian would also be helpful.
>
>  Thanks!
>  Apaar
>
>
>
>
>
>  -----Original Message-----
>  From: Arnaud HERITIER [mailto:aheritier@gmail.com]
>  Sent: Tuesday, March 18, 2008 4:59 PM
>  To: Maven Developers List
>  Subject: Re: parameter needed in maven-eclipse-plugin
>
>  Perhaps Brian or Carlos could have an opinion about it (I think one 
> of  them added it).
>  I didn't develop it and never played with this goal, thus I have no 
> idea  about it.
>
>  Arnaud
>
>  On Tue, Mar 18, 2008 at 9:08 PM, Apaar Trivedi  
> <at...@bluefishgroup.com> wrote:
>  > Hell,
>  >
>  >  We need one thing parameterized on the EclipseToMavenMojo.java in 
> the
>
>  > maven-eclipse-plugin which should be parameterized anyway.  In the

> > call  to osgiVersionToMavenVersion, it only allows 'false' to be  > 
> passed in for  the 'strip qualifier' parameter.
>  >
>  >  While the make-artifacts (which extends to-maven) target allows 
> you  > to  strip the qualifier, this is not a parameter that can be 
> used in  > the  to-maven target.  This is a problem because using
'to-maven'
>  > provides  artifacts with the proper names but the dependecies do 
> not  > resolve due  to the qualifiers on the versions.  While 
> make-artifacts  > provides  dependecies that resolve but the naming 
> convention of the  > groupId's and  artifactId's is incorrect.
>  >
>  >  Just a parameter -DstripQualifer that gets passed in to the call
to
>  >       osgiVersionToMavenVersion( String version, String
>  > forcedQualifier,  boolean stripQualifier )  would be perfect.
>  >
>  >  Can I add this as a parameter and get this checked in or can 
> someone  > do  it for me?  Aside from not providing proper naming 
> conventions,  > make-artifacts is deprecated.
>  >
>  >  Thanks for any help
>  >
>  >  Apaar Trivedi
>  >  O: (512) 469-9300 x 128
>  >  Blue Fish Development Group
>  >  http://www.bluefishgroup.com <http://www.bluefishgroup.com/>  Blue

> > Fish is Hiring! Check out www.bluefishgroup.com/careers  > 
> <http://www.bluefishgroup.com/careers>
>  >
>  >
>
>
>
>  --
>  ..........................................................
>  Arnaud HERITIER
>  ..........................................................
>  OCTO Technology - aheritier AT octo DOT com www.octo.com | 
> blog.octo.com
..........................................................
>  ASF - aheritier AT apache DOT org
>  www.apache.org | maven.apache.org
>  ...........................................................
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For 
> additional  commands, e-mail: dev-help@maven.apache.org
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org  For 
> additional commands, e-mail: dev-help@maven.apache.org
>
>



--
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional
commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: parameter needed in maven-eclipse-plugin

Posted by Arnaud HERITIER <ah...@gmail.com>.
You can open an issue and attach your patch.
We see with carlos if your change seems to be interesting to apply (I
think but I'm not an expert).

On Tue, Mar 18, 2008 at 11:02 PM, Apaar Trivedi
<at...@bluefishgroup.com> wrote:
> We have modified our copy locally and verified that what I am describing
>  can be parameterized and it works.
>
>  I can provide a patch for review if that is desired, or any feedback
>  from Carlos or Brian would also be helpful.
>
>  Thanks!
>  Apaar
>
>
>
>
>
>  -----Original Message-----
>  From: Arnaud HERITIER [mailto:aheritier@gmail.com]
>  Sent: Tuesday, March 18, 2008 4:59 PM
>  To: Maven Developers List
>  Subject: Re: parameter needed in maven-eclipse-plugin
>
>  Perhaps Brian or Carlos could have an opinion about it (I think one of
>  them added it).
>  I didn't develop it and never played with this goal, thus I have no idea
>  about it.
>
>  Arnaud
>
>  On Tue, Mar 18, 2008 at 9:08 PM, Apaar Trivedi
>  <at...@bluefishgroup.com> wrote:
>  > Hell,
>  >
>  >  We need one thing parameterized on the EclipseToMavenMojo.java in the
>
>  > maven-eclipse-plugin which should be parameterized anyway.  In the
>  > call  to osgiVersionToMavenVersion, it only allows 'false' to be
>  > passed in for  the 'strip qualifier' parameter.
>  >
>  >  While the make-artifacts (which extends to-maven) target allows you
>  > to  strip the qualifier, this is not a parameter that can be used in
>  > the  to-maven target.  This is a problem because using 'to-maven'
>  > provides  artifacts with the proper names but the dependecies do not
>  > resolve due  to the qualifiers on the versions.  While make-artifacts
>  > provides  dependecies that resolve but the naming convention of the
>  > groupId's and  artifactId's is incorrect.
>  >
>  >  Just a parameter -DstripQualifer that gets passed in to the call to
>  >       osgiVersionToMavenVersion( String version, String
>  > forcedQualifier,  boolean stripQualifier )  would be perfect.
>  >
>  >  Can I add this as a parameter and get this checked in or can someone
>  > do  it for me?  Aside from not providing proper naming conventions,
>  > make-artifacts is deprecated.
>  >
>  >  Thanks for any help
>  >
>  >  Apaar Trivedi
>  >  O: (512) 469-9300 x 128
>  >  Blue Fish Development Group
>  >  http://www.bluefishgroup.com <http://www.bluefishgroup.com/>  Blue
>  > Fish is Hiring! Check out www.bluefishgroup.com/careers
>  > <http://www.bluefishgroup.com/careers>
>  >
>  >
>
>
>
>  --
>  ..........................................................
>  Arnaud HERITIER
>  ..........................................................
>  OCTO Technology - aheritier AT octo DOT com www.octo.com | blog.octo.com
>  ..........................................................
>  ASF - aheritier AT apache DOT org
>  www.apache.org | maven.apache.org
>  ...........................................................
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional
>  commands, e-mail: dev-help@maven.apache.org
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>  For additional commands, e-mail: dev-help@maven.apache.org
>
>



-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: parameter needed in maven-eclipse-plugin

Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
Not I, if it's OSGI, it was probably Carlos.

-----Original Message-----
From: Arnaud HERITIER [mailto:aheritier@gmail.com] 
Sent: Tuesday, March 18, 2008 5:59 PM
To: Maven Developers List
Subject: Re: parameter needed in maven-eclipse-plugin

Perhaps Brian or Carlos could have an opinion about it (I think one of
them added it).
I didn't develop it and never played with this goal, thus I have no
idea about it.

Arnaud

On Tue, Mar 18, 2008 at 9:08 PM, Apaar Trivedi
<at...@bluefishgroup.com> wrote:
> Hell,
>
>  We need one thing parameterized on the EclipseToMavenMojo.java in the
>  maven-eclipse-plugin which should be parameterized anyway.  In the
call
>  to osgiVersionToMavenVersion, it only allows 'false' to be passed in
for
>  the 'strip qualifier' parameter.
>
>  While the make-artifacts (which extends to-maven) target allows you
to
>  strip the qualifier, this is not a parameter that can be used in the
>  to-maven target.  This is a problem because using 'to-maven' provides
>  artifacts with the proper names but the dependecies do not resolve
due
>  to the qualifiers on the versions.  While make-artifacts provides
>  dependecies that resolve but the naming convention of the groupId's
and
>  artifactId's is incorrect.
>
>  Just a parameter -DstripQualifer that gets passed in to the call to
>       osgiVersionToMavenVersion( String version, String
forcedQualifier,
>  boolean stripQualifier )
>  would be perfect.
>
>  Can I add this as a parameter and get this checked in or can someone
do
>  it for me?  Aside from not providing proper naming conventions,
>  make-artifacts is deprecated.
>
>  Thanks for any help
>
>  Apaar Trivedi
>  O: (512) 469-9300 x 128
>  Blue Fish Development Group
>  http://www.bluefishgroup.com <http://www.bluefishgroup.com/>
>  Blue Fish is Hiring! Check out www.bluefishgroup.com/careers
>  <http://www.bluefishgroup.com/careers>
>
>



-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: parameter needed in maven-eclipse-plugin

Posted by Apaar Trivedi <at...@bluefishgroup.com>.
We have modified our copy locally and verified that what I am describing
can be parameterized and it works.

I can provide a patch for review if that is desired, or any feedback
from Carlos or Brian would also be helpful.

Thanks!
Apaar
 
 

-----Original Message-----
From: Arnaud HERITIER [mailto:aheritier@gmail.com] 
Sent: Tuesday, March 18, 2008 4:59 PM
To: Maven Developers List
Subject: Re: parameter needed in maven-eclipse-plugin

Perhaps Brian or Carlos could have an opinion about it (I think one of
them added it).
I didn't develop it and never played with this goal, thus I have no idea
about it.

Arnaud

On Tue, Mar 18, 2008 at 9:08 PM, Apaar Trivedi
<at...@bluefishgroup.com> wrote:
> Hell,
>
>  We need one thing parameterized on the EclipseToMavenMojo.java in the

> maven-eclipse-plugin which should be parameterized anyway.  In the 
> call  to osgiVersionToMavenVersion, it only allows 'false' to be 
> passed in for  the 'strip qualifier' parameter.
>
>  While the make-artifacts (which extends to-maven) target allows you 
> to  strip the qualifier, this is not a parameter that can be used in 
> the  to-maven target.  This is a problem because using 'to-maven' 
> provides  artifacts with the proper names but the dependecies do not 
> resolve due  to the qualifiers on the versions.  While make-artifacts 
> provides  dependecies that resolve but the naming convention of the 
> groupId's and  artifactId's is incorrect.
>
>  Just a parameter -DstripQualifer that gets passed in to the call to
>       osgiVersionToMavenVersion( String version, String 
> forcedQualifier,  boolean stripQualifier )  would be perfect.
>
>  Can I add this as a parameter and get this checked in or can someone 
> do  it for me?  Aside from not providing proper naming conventions,  
> make-artifacts is deprecated.
>
>  Thanks for any help
>
>  Apaar Trivedi
>  O: (512) 469-9300 x 128
>  Blue Fish Development Group
>  http://www.bluefishgroup.com <http://www.bluefishgroup.com/>  Blue 
> Fish is Hiring! Check out www.bluefishgroup.com/careers  
> <http://www.bluefishgroup.com/careers>
>
>



--
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional
commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: parameter needed in maven-eclipse-plugin

Posted by Arnaud HERITIER <ah...@gmail.com>.
Perhaps Brian or Carlos could have an opinion about it (I think one of
them added it).
I didn't develop it and never played with this goal, thus I have no
idea about it.

Arnaud

On Tue, Mar 18, 2008 at 9:08 PM, Apaar Trivedi
<at...@bluefishgroup.com> wrote:
> Hell,
>
>  We need one thing parameterized on the EclipseToMavenMojo.java in the
>  maven-eclipse-plugin which should be parameterized anyway.  In the call
>  to osgiVersionToMavenVersion, it only allows 'false' to be passed in for
>  the 'strip qualifier' parameter.
>
>  While the make-artifacts (which extends to-maven) target allows you to
>  strip the qualifier, this is not a parameter that can be used in the
>  to-maven target.  This is a problem because using 'to-maven' provides
>  artifacts with the proper names but the dependecies do not resolve due
>  to the qualifiers on the versions.  While make-artifacts provides
>  dependecies that resolve but the naming convention of the groupId's and
>  artifactId's is incorrect.
>
>  Just a parameter -DstripQualifer that gets passed in to the call to
>       osgiVersionToMavenVersion( String version, String forcedQualifier,
>  boolean stripQualifier )
>  would be perfect.
>
>  Can I add this as a parameter and get this checked in or can someone do
>  it for me?  Aside from not providing proper naming conventions,
>  make-artifacts is deprecated.
>
>  Thanks for any help
>
>  Apaar Trivedi
>  O: (512) 469-9300 x 128
>  Blue Fish Development Group
>  http://www.bluefishgroup.com <http://www.bluefishgroup.com/>
>  Blue Fish is Hiring! Check out www.bluefishgroup.com/careers
>  <http://www.bluefishgroup.com/careers>
>
>



-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org