You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/07/17 06:08:31 UTC

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2490
  
    Thanks for implementing such a great feature! 
    
    1. Could you rebase against the current master? Since filenames were changes, it would be easier to review after rebasing
    2. Regarding UX
    
    - It would be nice to provide shortcut to trigger this feature (overriding `CTRL+F`, `CMD+F` or using a different key)
    - It would be great if cursor move to the next search result if I stroke `enter` key like other editor do.
    - Can we provide the search result count? (refer the screenshot)
    
    ![image](https://user-images.githubusercontent.com/4968473/28256928-c24bd79c-6b01-11e7-8961-87c758238cd2.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---