You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucy.apache.org by ma...@apache.org on 2006/10/28 05:25:57 UTC
svn commit: r468626 - in /lucene/lucy/trunk:
charmonizer/src/Charmonizer/Core/ModHandler.charm perl/buildlib/Lucy/Build.pm
Author: marvin
Date: Fri Oct 27 20:25:57 2006
New Revision: 468626
URL: http://svn.apache.org/viewvc?view=rev&rev=468626
Log:
Don't valgrind the compiler (you'll regret it). Fix a minor memory leak.
Modified:
lucene/lucy/trunk/charmonizer/src/Charmonizer/Core/ModHandler.charm
lucene/lucy/trunk/perl/buildlib/Lucy/Build.pm
Modified: lucene/lucy/trunk/charmonizer/src/Charmonizer/Core/ModHandler.charm
URL: http://svn.apache.org/viewvc/lucene/lucy/trunk/charmonizer/src/Charmonizer/Core/ModHandler.charm?view=diff&rev=468626&r1=468625&r2=468626
==============================================================================
--- lucene/lucy/trunk/charmonizer/src/Charmonizer/Core/ModHandler.charm (original)
+++ lucene/lucy/trunk/charmonizer/src/Charmonizer/Core/ModHandler.charm Fri Oct 27 20:25:57 2006
@@ -86,6 +86,7 @@
char *command;
size_t command_len = 1; /* terminating null */
int i;
+ int retval;
/* rebuild the command line args, minus the name of this utility */
for (i = 1; i < argc; i++) {
@@ -111,7 +112,9 @@
, "w", stderr);
/* run the commmand and return its value to the parent process */
- return system(command);
+ retval = system(command);
+ free(command);
+ return retval;
}
METAQUOTE;
Modified: lucene/lucy/trunk/perl/buildlib/Lucy/Build.pm
URL: http://svn.apache.org/viewvc/lucene/lucy/trunk/perl/buildlib/Lucy/Build.pm?view=diff&rev=468626&r1=468625&r2=468626
==============================================================================
--- lucene/lucy/trunk/perl/buildlib/Lucy/Build.pm (original)
+++ lucene/lucy/trunk/perl/buildlib/Lucy/Build.pm Fri Oct 27 20:25:57 2006
@@ -155,7 +155,7 @@
my $os_name = lc( $Config{osname} );
my $flags = "$Config{ccflags} $EXTRA_CCFLAGS";
my $verbosity = $ENV{DEBUG_CHARM} ? 2 : 1;
- my $cc = "$VALGRIND$Config{cc}";
+ my $cc = "$Config{cc}";
open( my $infile_fh, '>', $lucyconf_in )
or die "Can't open '$lucyconf_in': $!";
print $infile_fh qq|