You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Brian Bockelman (JIRA)" <ji...@apache.org> on 2008/11/18 05:41:44 UTC

[jira] Created: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Current Ganglia metrics implementation is incompatible with Ganglia 3.1
-----------------------------------------------------------------------

                 Key: HADOOP-4675
                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
             Project: Hadoop Core
          Issue Type: Improvement
          Components: metrics
    Affects Versions: 0.18.2
            Reporter: Brian Bockelman


Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by jason hadoop <ja...@gmail.com>.
If we dig into the wire protocol, we should also add a cluster name
parameter, which will simplify the ganglia config in
hadoop-metrics.properties and simply the cluster reporting in the
gmetad.conf file

On Tue, Jan 27, 2009 at 8:14 AM, Jeff Hammerbacher (JIRA)
<ji...@apache.org>wrote:

>
>     [
> https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Jeff Hammerbacher updated HADOOP-4675:
> --------------------------------------
>
>    Comment: was deleted
>
> > Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> > -----------------------------------------------------------------------
> >
> >                 Key: HADOOP-4675
> >                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
> >             Project: Hadoop Core
> >          Issue Type: Improvement
> >          Components: metrics
> >    Affects Versions: 0.18.2
> >            Reporter: Brian Bockelman
> >             Fix For: 0.19.1, 0.20.0
> >
> >         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch,
> HADOOP-4675-4.patch, hadoop-4675.patch
> >
> >
> > Ganglia changed its wire protocol in the 3.1.x series; the current
> implementation only works for 3.0.x.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Attachment: hadoop-4675.patch

The attached patch (which includes the patch for HADOOP-3422 in order to make things work...) should provide Ganglia 3.1 support.

Note that this patch probably will be conflicting in Hudson until HADOOP-3422 lands in trunk.  I'll rebase things then.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>         Attachments: hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "zhangwei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhangwei updated HADOOP-4675:
-----------------------------

    Attachment: hadoop-4675-3.patch

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "zhangwei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhangwei updated HADOOP-4675:
-----------------------------

    Attachment: hadoop-4675-3.patch

add group attribute 

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683655#action_12683655 ] 

Brian Bockelman commented on HADOOP-4675:
-----------------------------------------

Hey Steve,

1) This does not break Ganglia 3.0.  It gives a subclass of the Ganglia 3.0 implementation that is compatible with 3.1.

2) I'll have to work on this - we're currently using the patch for 0.19, so I haven't looked at the DNS class yet.  Can you give an example (or fix the patch yourself) :)?

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Hammerbacher updated HADOOP-4675:
--------------------------------------

    Comment: was deleted

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.1, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Attachment: hadoop-4675-2.patch

Fix a build issue.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>         Attachments: hadoop-4675-2.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693415#action_12693415 ] 

Brian Bockelman commented on HADOOP-4675:
-----------------------------------------

Ok - I think the patch is ready - why is there no "Submit Patch" from JIRA?  Did I do something wrong?

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707305#action_12707305 ] 

Hadoop QA commented on HADOOP-4675:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12407207/HADOOP-4675-v7.patch
  against trunk revision 772844.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 3 new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/299/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/299/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/299/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/299/console

This message is automatically generated.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.19.2, 0.20.1
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, HADOOP-4675-v7.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693756#action_12693756 ] 

Steve Loughran commented on HADOOP-4675:
----------------------------------------

Looks good to me, +1. 

One thing to consider -in future- is moving the code to listen (and later validate) the ganglia 3.1 messages should be moved somewhere where it can be redistributed/reused in other tests and tools. That can wait until there is more validation. 

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "zhangwei (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650842#action_12650842 ] 

zhangwei commented on HADOOP-4675:
----------------------------------

Hi, Brian

I tested it on my cluster,which has ganglia 3.1.1 installed.I add a little code simply  based on your patch:

+    String GroupName = name.substring(0,name.lastIndexOf("."))
. . . . . .
    xdr_int(dmax);        // dmax, the maximum data value
    //xdr_string("");       // Empty extra_value field for Ganglia 3.1.
+    xdr_int(1);   //this means Num Of the Element follow by
+    xdr_string("GROUP");
+    xdr_string(GroupName);
    for (SocketAddress socketAddress : metricsServers) {
      DatagramPacket packet 

And it seems OK.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Attachment: HADOOP-4675-v5.patch

I believe this works - Steve, can you look over my usage of the DNS class?

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley reopened HADOOP-4675:
---------------------------------

      Assignee: Brian Bockelman

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "zhangwei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhangwei updated HADOOP-4675:
-----------------------------

    Attachment: HADOOP-4675-4.patch

I follow the wiki "HowToContribute" step by step and create the new patch.I hope it woks :-)

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.1, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707252#action_12707252 ] 

Hadoop QA commented on HADOOP-4675:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12407207/HADOOP-4675-v7.patch
  against trunk revision 772688.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 3 new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    -1 release audit.  The applied patch generated 476 release audit warnings (more than the trunk's current 475 warnings).

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/296/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/296/artifact/trunk/current/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/296/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/296/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/296/console

This message is automatically generated.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.19.2, 0.20.1
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, HADOOP-4675-v7.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Status: In Progress  (was: Patch Available)

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "zhangwei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhangwei updated HADOOP-4675:
-----------------------------

    Attachment: HADOOP-4675-4.patch

the patch's content use chinese chars: 工作副本 which means "revision"
I translate into english.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.1, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Alex Loddengaard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667690#action_12667690 ] 

Alex Loddengaard commented on HADOOP-4675:
------------------------------------------

I'll be out of the country starting Friday, 1/23, returning Monday,
2/2.  I will not be reachable at all while I am gone.  Please contact
Jeff Hammerbacher (hammer@cloudera.com) or Philip Zeyliger
(philip@cloudera.com) in my leave.

Thanks!  I will get back to you in February.

Alex


> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.1, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "zhangwei (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650533#action_12650533 ] 

hustwei edited comment on HADOOP-4675 at 11/25/08 3:24 AM:
------------------------------------------------------------

hadoop-4675-3.patch :add group attribute which use the prefix of the metric name.


      was (Author: hustwei):
    add group attribute 
  
> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Fix Version/s: 0.20.0
                   0.19.1
           Status: Patch Available  (was: Open)

I can confirm that the alterations to my patch do indeed appear to work.

Submitting patch to Hudson.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.1, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650600#action_12650600 ] 

Brian Bockelman commented on HADOOP-4675:
-----------------------------------------

Hey zhangwei,

The group attribute stuff is a good improvement.  Have you tested it on your cluster?  I'll perhaps get to do this today or tomorrow; we're going to be upgrading to Hadoop 0.19.0 soon, which will allow me to slip a few new patches in.

Brian

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667685#action_12667685 ] 

Steve Loughran commented on HADOOP-4675:
----------------------------------------

# does this break ganglia 3.0?
# The code works out its hostname in a static constructor

{code}
+        InetAddress localMachine = InetAddress.getLocalHost();
+        hostName = localMachine.getHostName();
{code}
For 0.20 and onwards, this patch should use the code in org.apache.hadoop.net.DNS, rather than try and do this itself. The DNS class has caching and fallback for machines that don't know who they are.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.1, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Status: Patch Available  (was: Reopened)

Ok, submitting version 6 to Hudson.  Includes a test case and correct DNS usage.  Go Hudson, go!

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697677#action_12697677 ] 

Hadoop QA commented on HADOOP-4675:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12404072/HADOOP-4675-v6.patch
  against trunk revision 763728.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/174/console

This message is automatically generated.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Attachment: HADOOP-4675-v6.patch

Hm - found a bug in the v5 patch.  This next one currently uses the DNS class correctly as Steve suggested.

This next one includes a test case for Ganglia -- it's quite simple.  All it does is configure the MiniDFSCluster to report to Ganglia31, and then starts up a separate thread which listens for metrics.  It verifies that the hostname is properly set inside the packet sent to Ganglia, but does not verify that all the formatting is correct.

This appears to be the first test for Ganglia?  Probably should have written it awhile ago.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley resolved HADOOP-4675.
---------------------------------

    Resolution: Incomplete

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.2, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Attachment: HADOOP-4675-v7.patch

v7 of the patch - I think I've fixed the 'patch' issue in Hudson - just a bum development environment on my laptop.

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.19.2, 0.20.1
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, HADOOP-4675-v7.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "zhangwei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhangwei updated HADOOP-4675:
-----------------------------

    Attachment:     (was: HADOOP-4675-4.patch)

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>             Fix For: 0.19.1, 0.20.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "zhangwei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhangwei updated HADOOP-4675:
-----------------------------

    Attachment:     (was: hadoop-4675-3.patch)

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "zhangwei (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650514#action_12650514 ] 

zhangwei commented on HADOOP-4675:
----------------------------------

I test the patch OK.And I suggest to add the group attribute in the extra data
the metric in Ganglia3.1.*  has the attribute,so i think to put the prefix of the metric name to the group name.
for example: 
metric :dfs.namenode.FilesCreated --> group: dfs.namenode

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>         Attachments: hadoop-4675-2.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Fix Version/s: 0.20.1
           Status: Patch Available  (was: Open)

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.19.2, 0.20.1
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, HADOOP-4675-v7.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Bockelman updated HADOOP-4675:
------------------------------------

    Status: Open  (was: Patch Available)

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.19.2
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, HADOOP-4675-v7.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648494#action_12648494 ] 

Brian Bockelman commented on HADOOP-4675:
-----------------------------------------

Looking at the new Ganglia wire protocol, we'll probably need to do the following:
1) Implement more XDR serializations.  3.0.x protocol sends all data as strings; 3.1.x correctly sends float data as XDR floats.
2) Test and verify sending Longs as floats in Ganglia actually works.  This has been discussed, but I'm not sure it's entirely functional... maybe get a test case going?
3) Probably this will result in a new GangliaContext31 class, as I don't see any clean way to merge the two protocols together into one class.
  - The patch for HADOOP-3422 caused a new metric name to be generated in the emitRecord class; we could reuse this if it was separated out into a new function.

Brian

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4675) Current Ganglia metrics implementation is incompatible with Ganglia 3.1

Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Oskarsson updated HADOOP-4675:
------------------------------------

    Fix Version/s:     (was: 0.20.1)
                       (was: 0.19.2)
                   0.21.0
           Status: Open  (was: Patch Available)

Could you have a look at these findbugs warnings and see if it is possible to fix those?

http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/299/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html

> Current Ganglia metrics implementation is incompatible with Ganglia 3.1
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-4675
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4675
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.18.2
>            Reporter: Brian Bockelman
>            Assignee: Brian Bockelman
>             Fix For: 0.21.0
>
>         Attachments: hadoop-4675-2.patch, hadoop-4675-3.patch, HADOOP-4675-4.patch, HADOOP-4675-v5.patch, HADOOP-4675-v6.patch, HADOOP-4675-v7.patch, hadoop-4675.patch
>
>
> Ganglia changed its wire protocol in the 3.1.x series; the current implementation only works for 3.0.x.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.