[GitHub] [rocketmq-client-cpp] vongosling commented on a change in pull request #256: feat(jsoncpp): update jsoncpp to 0.10.7 in order to fix build error by gcc7+

[GitBox <gi...@apache.org>]

vongosling commented on a change in pull request #256: feat(jsoncpp): update jsoncpp to 0.10.7 in order to fix build error by gcc7+
URL: https://github.com/apache/rocketmq-client-cpp/pull/256#discussion_r383108909
 
 

 ##########
 File path: README.md
 ##########
 @@ -33,9 +33,9 @@ RocketMQ-Client-CPP is the C/C++ client of Apache RocketMQ, a distributed messag
 	- bzip2-devel 1.0.6: boost depend it
 	- zlib-devel
 
-The **build.sh** script will automatically download and build the dependency libraries including libevent, json and boost. It will save libraries under rocketmq-client-cpp folder, and then build both static and shared libraries for rocketmq-client. If the dependent libraries are built failed, you could try to build it manually with sources [libevent 2.0.22](https://github.com/libevent/libevent/archive/release-2.0.22-stable.zip "lib event 2.0.22"), [jsoncpp 0.10.6](https://github.com/open-source-parsers/jsoncpp/archive/0.10.6.zip  "jsoncpp 0.10.6"), [boost 1.58.0](http://sourceforge.net/projects/boost/files/boost/1.58.0/boost_1_58_0.tar.gz "boost 1.58.0")
+The **build.sh** script will automatically download and build the dependency libraries including libevent, json and boost. It will save libraries under rocketmq-client-cpp folder, and then build both static and shared libraries for rocketmq-client. If the dependent libraries are built failed, you could try to build it manually with sources [libevent 2.0.22](https://github.com/libevent/libevent/archive/release-2.0.22-stable.zip "lib event 2.0.22"), [jsoncpp 0.10.7](https://github.com/open-source-parsers/jsoncpp/archive/0.10.7.zip  "jsoncpp 0.10.6"), [boost 1.58.0](http://sourceforge.net/projects/boost/files/boost/1.58.0/boost_1_58_0.tar.gz "boost 1.58.0")
 
 Review comment:
   There is still jsoncpp 0.10.6 in your comment. Whats' more, I could find the release note about 0.10.7 and figure out does it make an change for its own dependency. At last, Do we have the upgrade plan for jsoncpp 1.x.y?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services