[GitHub] [commons-numbers] Schamschi opened a new pull request #68: [NUMBERS-133] Use iteration algorithm from bounded trial division in Primes.nextPrime(int)

[GitBox <gi...@apache.org>]

Schamschi opened a new pull request #68: [NUMBERS-133] Use iteration algorithm from bounded trial division in Primes.nextPrime(int)
URL: https://github.com/apache/commons-numbers/pull/68
 
 
   I'm not sure if "potentialPrimes" is a good name for the method that generates the iterator, because it doesn't reveal anything about the purpose of the argument (a lower bound). However, "potentialPrimesBeyond" or something similar would be wrong, because the argument itself is also included in the possible range of results. The most descriptive name would be "potentialPrimesGreaterThanOrEqualTo", but this is horribly verbose. "potentialPrimesNotSmallerThan" is only slightly less verbose, and it contains a negation, which is confusing. So I've left it at "potentialPrimes", but any better suggestions are welcome. At least it's a package-private method, so the method name could still be changed any time in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services