[GitHub] [nifi] patricker commented on a change in pull request #3763: NIFI-6684 Add more property to Hive3ConnectionPool

[GitBox <gi...@apache.org>]

patricker commented on a change in pull request #3763: NIFI-6684 Add more property to Hive3ConnectionPool
URL: https://github.com/apache/nifi/pull/3763#discussion_r358579051
 
 

 ##########
 File path: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/dbcp/hive/Hive3ConnectionPool.java
 ##########
 @@ -178,6 +278,12 @@ protected void init(final ControllerServiceInitializationContext context) {
         props.add(MAX_WAIT_TIME);
         props.add(MAX_TOTAL_CONNECTIONS);
         props.add(VALIDATION_QUERY);
+        props.add(MIN_IDLE);
 
 Review comment:
   Hey @mattyb149. Your right, my bad.  It's not much of an excuse on my end, but basically I compared this to the previous ticket where properties were added, saw that it was a copy/paste from that previous addition to the DBCP properties, and now we have properties in both that say they allow EL but don't actually.... https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java#L312 Is the same.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services