You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-commits@hadoop.apache.org by cn...@apache.org on 2013/06/12 20:54:56 UTC

svn commit: r1492364 - in /hadoop/common/trunk/hadoop-mapreduce-project: CHANGES.txt hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestTaskLog.java

Author: cnauroth
Date: Wed Jun 12 18:54:56 2013
New Revision: 1492364

URL: http://svn.apache.org/r1492364
Log:
TestTaskLog fails on Windows because of path separators missmatch. Contributed by Ivan Mitic.

Modified:
    hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
    hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestTaskLog.java

Modified: hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt?rev=1492364&r1=1492363&r2=1492364&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt Wed Jun 12 18:54:56 2013
@@ -508,6 +508,9 @@ Release 2.1.0-beta - UNRELEASED
     MAPREDUCE-5315.  DistCp reports success even on failure. (mithun and jlowe
     via daryn)
 
+    MAPREDUCE-5259. TestTaskLog fails on Windows because of path separators
+    missmatch. (Ivan Mitic via cnauroth)
+
   BREAKDOWN OF HADOOP-8562 SUBTASKS
 
     MAPREDUCE-4739. Some MapReduce tests fail to find winutils.

Modified: hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestTaskLog.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestTaskLog.java?rev=1492364&r1=1492363&r2=1492364&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestTaskLog.java (original)
+++ hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestTaskLog.java Wed Jun 12 18:54:56 2013
@@ -55,7 +55,8 @@ public class TestTaskLog {
     when(taid.toString()).thenReturn("JobId");
 
     File f = TaskLog.getTaskLogFile(taid, true, LogName.STDOUT);
-    assertTrue(f.getAbsolutePath().endsWith("testString/stdout"));
+    assertTrue(f.getAbsolutePath().endsWith("testString"
+        + File.separatorChar + "stdout"));
 
     // test getRealTaskLogFileLocation
 
@@ -69,11 +70,14 @@ public class TestTaskLog {
     TaskLog.syncLogs("location", taid, true);
 
     assertTrue(indexFile.getAbsolutePath().endsWith(
-        "userlogs/job_job_0001/JobId.cleanup/log.index"));
+        "userlogs" + File.separatorChar + "job_job_0001"
+        + File.separatorChar + "JobId.cleanup"
+        + File.separatorChar + "log.index"));
 
     f = TaskLog.getRealTaskLogFileLocation(taid, true, LogName.DEBUGOUT);
     if (f != null) {
-      assertTrue(f.getAbsolutePath().endsWith("location/debugout"));
+      assertTrue(f.getAbsolutePath().endsWith("location"
+          + File.separatorChar + "debugout"));
       FileUtils.copyFile(indexFile, f);
     }
     // test obtainLogDirOwner