You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/01 11:00:37 UTC
[GitHub] [arrow-datafusion] askoa opened a new pull request, #3674: Fail if field lengths are not same in INTERSECT and EXPECT
askoa opened a new pull request, #3674:
URL: https://github.com/apache/arrow-datafusion/pull/3674
# Which issue does this PR close?
Closes #3632
# Are there any user-facing changes?
Users will see failure if they are using INTERSECT and EXPECT on tables with different field count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3674: Fail if field lengths are not same in INTERSECT and EXPECT
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3674:
URL: https://github.com/apache/arrow-datafusion/pull/3674#issuecomment-1264508159
Benchmark runs are scheduled for baseline = 6d2b417def2d536e81eb80e082d9cc3ca4e7f5fc and contender = 928032faa06f1fc0f6f1add8106dc7ac1d976c3a. 928032faa06f1fc0f6f1add8106dc7ac1d976c3a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8db55863e8e9480fa4d9cab0a1bae106...7841e2c066d840379c65f20a71f57b8f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/26ff5ab73a3548eda64a75f2f05dda38...81d62aa1dcba421eabb3e458dbdfc8f0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bf4335338c0b48dfa63edf70226f1b5a...1b9b4f7736c143f9950a3951da1f4721/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6a06617b53a94b4aab169a5e075fab14...9661c189dac44cb988026317a9e64c9b/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] askoa commented on a diff in pull request #3674: Fail if field lengths are not same in INTERSECT and EXPECT
Posted by GitBox <gi...@apache.org>.
askoa commented on code in PR #3674:
URL: https://github.com/apache/arrow-datafusion/pull/3674#discussion_r985088851
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -781,6 +781,16 @@ impl LogicalPlanBuilder {
join_type: JoinType,
is_all: bool,
) -> Result<LogicalPlan> {
+ let left_len = left_plan.schema().fields().len();
+ let right_len = right_plan.schema().fields().len();
+
+ if left_len != right_len {
+ return Err(DataFusionError::Plan(format!(
+ "Expected the no. of fields to be the same. Left fields count = {} and right fields count = {} are not the same.",
Review Comment:
I updated based on your suggestion. Let me know if that works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 merged pull request #3674: Fail if field lengths are not same in INTERSECT and EXPECT
Posted by GitBox <gi...@apache.org>.
HaoYang670 merged PR #3674:
URL: https://github.com/apache/arrow-datafusion/pull/3674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #3674: Fail if field lengths are not same in INTERSECT and EXPECT
Posted by GitBox <gi...@apache.org>.
xudong963 commented on code in PR #3674:
URL: https://github.com/apache/arrow-datafusion/pull/3674#discussion_r985088106
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -781,6 +781,16 @@ impl LogicalPlanBuilder {
join_type: JoinType,
is_all: bool,
) -> Result<LogicalPlan> {
+ let left_len = left_plan.schema().fields().len();
+ let right_len = right_plan.schema().fields().len();
+
+ if left_len != right_len {
+ return Err(DataFusionError::Plan(format!(
+ "Expected the no. of fields to be the same. Left fields count = {} and right fields count = {} are not the same.",
Review Comment:
```suggestion
"each INTERSECT/EXCEPT query must have the same number of columns. Left fields count = {} and right fields count = {} are not the same.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #3674: Fail if field lengths are not same in INTERSECT and EXPECT
Posted by GitBox <gi...@apache.org>.
xudong963 commented on code in PR #3674:
URL: https://github.com/apache/arrow-datafusion/pull/3674#discussion_r985088329
##########
datafusion/core/tests/sql/intersection.rs:
##########
@@ -85,3 +85,19 @@ async fn test_intersect_distinct() -> Result<()> {
assert_batches_eq!(expected, &actual);
Ok(())
}
+
+#[tokio::test]
+#[should_panic(
Review Comment:
You can reference the test in https://github.com/apache/arrow-datafusion/pull/3638/files which is more elegant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] askoa commented on a diff in pull request #3674: Fail if field lengths are not same in INTERSECT and EXPECT
Posted by GitBox <gi...@apache.org>.
askoa commented on code in PR #3674:
URL: https://github.com/apache/arrow-datafusion/pull/3674#discussion_r985090320
##########
datafusion/core/tests/sql/intersection.rs:
##########
@@ -85,3 +85,19 @@ async fn test_intersect_distinct() -> Result<()> {
assert_batches_eq!(expected, &actual);
Ok(())
}
+
+#[tokio::test]
+#[should_panic(
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] askoa commented on pull request #3674: Fail if field lengths are not same in INTERSECT and EXPECT
Posted by GitBox <gi...@apache.org>.
askoa commented on PR #3674:
URL: https://github.com/apache/arrow-datafusion/pull/3674#issuecomment-1264354207
CI failure unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org