You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "laskoviymishka (via GitHub)" <gi...@apache.org> on 2026/06/29 12:33:48 UTC
[PR] fix(table): return ([]string, error) from writePositionDeletesForFiles [iceberg-go]
laskoviymishka opened a new pull request, #1342:
URL: https://github.com/apache/iceberg-go/pull/1342
A bare `return err` returned a single value where the function now returns ([]string, error), so the table package — and every package that imports it — failed to compile, turning main red.
Silent semantic merge conflict: #1256 added the requireWriteFileIO guard with `return err` while the function still returned only error; #1298 later widened the signature and converted the returns it could see, but its base predated #1256 so it never saw that one. Each PR compiled alone; only the merge breaks, and with no textual conflict git didn't flag it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): return ([]string, error) from writePositionDeletesForFiles [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1342:
URL: https://github.com/apache/iceberg-go/pull/1342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org