You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/14 01:40:11 UTC
[GitHub] [spark] YannisSismanis opened a new pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
YannisSismanis opened a new pull request #33985:
URL: https://github.com/apache/spark/pull/33985
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
The join condition returned from ExtractEquiJoinKeys does not correspond to the equi-join on the extracted left and right keys. A call site can be risky if it is not aware of that.
The pattern extractor should extract the rest of original join condition as well.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919428749
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143272/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920326489
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47822/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919426236
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47775/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919499861
**[Test build #143275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143275/testReport)** for PR 33985 at commit [`62b7307`](https://github.com/apache/spark/commit/62b73079e311a12f5003cfa13f744904cc53ccf6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919509697
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920331164
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47822/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919472230
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47777/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919472230
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47777/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919424810
**[Test build #143272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143272/testReport)** for PR 33985 at commit [`460c6b0`](https://github.com/apache/spark/commit/460c6b046dcb2813985f039ba5bfa7545a5918bc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #33985: [SPARK-36745][SQL] ExtractEquiJoinKeys should return the original predicates on join keys
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #33985:
URL: https://github.com/apache/spark/pull/33985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919469168
**[Test build #143274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143274/testReport)** for PR 33985 at commit [`efd33df`](https://github.com/apache/spark/commit/efd33df56a0223964af1443668ee2be494b8a87d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920468454
**[Test build #143319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143319/testReport)** for PR 33985 at commit [`0a94c1e`](https://github.com/apache/spark/commit/0a94c1e874d7efde2fb2a74e40a05a1e4307f50d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920331189
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47822/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919389369
**[Test build #143270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143270/testReport)** for PR 33985 at commit [`cf10e32`](https://github.com/apache/spark/commit/cf10e32306749ea7c4505a16c6d961afefec0e1e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920204132
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33985:
URL: https://github.com/apache/spark/pull/33985#discussion_r708927877
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -461,11 +462,10 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
object StreamingJoinStrategy extends Strategy {
override def apply(plan: LogicalPlan): Seq[SparkPlan] = {
plan match {
- case ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, condition, left, right, _)
- if left.isStreaming && right.isStreaming =>
-
+ case ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, non_keyed_condition, _,
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919393375
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143270/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919426223
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47775/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919631445
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143275/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919509715
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919631445
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143275/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919509715
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919472215
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47777/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919428702
**[Test build #143272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143272/testReport)** for PR 33985 at commit [`460c6b0`](https://github.com/apache/spark/commit/460c6b046dcb2813985f039ba5bfa7545a5918bc).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920204132
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920331189
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47822/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920298345
**[Test build #143319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143319/testReport)** for PR 33985 at commit [`0a94c1e`](https://github.com/apache/spark/commit/0a94c1e874d7efde2fb2a74e40a05a1e4307f50d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919428749
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143272/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920298345
**[Test build #143319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143319/testReport)** for PR 33985 at commit [`0a94c1e`](https://github.com/apache/spark/commit/0a94c1e874d7efde2fb2a74e40a05a1e4307f50d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919473441
**[Test build #143274 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143274/testReport)** for PR 33985 at commit [`efd33df`](https://github.com/apache/spark/commit/efd33df56a0223964af1443668ee2be494b8a87d).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-918724059
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920469302
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143319/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33985:
URL: https://github.com/apache/spark/pull/33985#discussion_r708929828
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -67,7 +67,7 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
// Only hash join and sort merge join need the normalization. Here we catch all Joins with
// join keys, assuming Joins with join keys are always planned as hash join or sort merge
// join. It's very unlikely that we will break this assumption in the near future.
- case j @ ExtractEquiJoinKeys(_, leftKeys, rightKeys, condition, _, _, _)
+ case j @ ExtractEquiJoinKeys(_, leftKeys, rightKeys, condition, _, _, _, _)
Review comment:
We can simplify the code here now. We don't need to restore the original join condition by constructing the `EqualTo` expressions manually. We can just use the new `predicatesOfJoinKeys`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919395392
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47773/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919473506
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143274/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919473506
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143274/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919469168
**[Test build #143274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143274/testReport)** for PR 33985 at commit [`efd33df`](https://github.com/apache/spark/commit/efd33df56a0223964af1443668ee2be494b8a87d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919426236
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47775/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33985:
URL: https://github.com/apache/spark/pull/33985#discussion_r708927660
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
##########
@@ -197,15 +203,15 @@ object ExtractEquiJoinKeys extends Logging with PredicateHelper {
Seq((Coalesce(Seq(l, Literal.default(l.dataType))),
Coalesce(Seq(r, Literal.default(r.dataType)))),
(IsNull(l), IsNull(r))
- )
+ ) // (coalesce(l, default) = coalesce(r, default)) and (isnull(l) = isnull(r))
case EqualNullSafe(l, r) if canEvaluate(l, right) && canEvaluate(r, left) =>
Seq((Coalesce(Seq(r, Literal.default(r.dataType))),
Coalesce(Seq(l, Literal.default(l.dataType)))),
(IsNull(r), IsNull(l))
- )
- case other => None
+ ) // Same as above with left/right reversed.
+ case _ => None
}
- val otherPredicates = predicates.filterNot {
+ val (keyed_predicates, non_keyed_predicates) = predicates.partition {
Review comment:
this violates the java/scala naming convention. how about `predicatesOfJoinKeys` and `otherPredicates`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-918724059
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919395407
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47773/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919389369
**[Test build #143270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143270/testReport)** for PR 33985 at commit [`cf10e32`](https://github.com/apache/spark/commit/cf10e32306749ea7c4505a16c6d961afefec0e1e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919395407
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47773/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919499861
**[Test build #143275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143275/testReport)** for PR 33985 at commit [`62b7307`](https://github.com/apache/spark/commit/62b73079e311a12f5003cfa13f744904cc53ccf6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33985:
URL: https://github.com/apache/spark/pull/33985#discussion_r708928055
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/LogicalQueryStageStrategy.scala
##########
@@ -43,11 +43,13 @@ object LogicalQueryStageStrategy extends Strategy with PredicateHelper {
}
def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
- case ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, condition, left, right, hint)
+ case ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, non_keyed_condition, _,
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919393375
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143270/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919388316
add to whitelist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919504843
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47778/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-919393321
**[Test build #143270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143270/testReport)** for PR 33985 at commit [`cf10e32`](https://github.com/apache/spark/commit/cf10e32306749ea7c4505a16c6d961afefec0e1e).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] YannisSismanis commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
YannisSismanis commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920300315
There is a normalization of the keys for the join at the code below, that
probably doesn't pre-exist in the conditionOfJoinKeys
On Wed, Sep 15, 2021 at 12:49 AM Wenchen Fan ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In
> sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
> <https://github.com/apache/spark/pull/33985#discussion_r708929828>:
>
> > @@ -67,7 +67,7 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
> // Only hash join and sort merge join need the normalization. Here we catch all Joins with
> // join keys, assuming Joins with join keys are always planned as hash join or sort merge
> // join. It's very unlikely that we will break this assumption in the near future.
> - case j @ ExtractEquiJoinKeys(_, leftKeys, rightKeys, condition, _, _, _)
> + case j @ ExtractEquiJoinKeys(_, leftKeys, rightKeys, condition, _, _, _, _)
>
> We can simplify the code here now. We don't need to restore the original
> join condition by constructing the EqualTo expressions manually. We can
> just use the new predicatesOfJoinKeys
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/33985#pullrequestreview-754779063>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AVNFVECXZUI3XRCUAIVAB3LUCBF2FANCNFSM5D7BNYPQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920469302
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143319/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33985: [SPARK-36745][SQL] ExtractEquiJoinKeys should return the original predicates on join keys
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-920584019
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] YannisSismanis commented on pull request #33985: [WIP][SPARK-36745][SQL] Cleanup pattern ExtractEquiJoinKeys
Posted by GitBox <gi...@apache.org>.
YannisSismanis commented on pull request #33985:
URL: https://github.com/apache/spark/pull/33985#issuecomment-918724093
@cloud-fan @sigmod FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org