[GitHub] [submarine] jasoonn commented on a change in pull request #324: Submarine-515. [WEB]Implement Hyper parameters in experiment page.

[GitBox <gi...@apache.org>]

jasoonn commented on a change in pull request #324:
URL: https://github.com/apache/submarine/pull/324#discussion_r444009075



##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.html
##########
@@ -17,4 +17,17 @@
   ~ under the License.
   -->
 
-<p>hyper-params works!</p>
+<nz-table #basicTable [nzFrontPagination]="false" [nzData]="paramsList">
+  <thead>
+    <tr>
+      <th>Key</th>
+      <th>Value</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr *ngFor="let data of basicTable.data">
+      <td>{{data.key}}</td>
+      <td>{{data.value}}</td>
+    </tr>
+  </tbody>
+</nz-table>

Review comment:
       No newline at the end of the file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org