[GitHub] [kafka] guozhangwang commented on a change in pull request #9095: KAFKA-10321: fix infinite blocking for global stream thread startup

[GitBox <gi...@apache.org>]

guozhangwang commented on a change in pull request #9095:
URL: https://github.com/apache/kafka/pull/9095#discussion_r462589015



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java
##########
@@ -173,6 +178,18 @@ public boolean stillRunning() {
         }
     }
 
+    public boolean inErrorState() {
+        synchronized (stateLock) {
+            return state.inErrorState();
+        }
+    }
+
+    public boolean stillInitializing() {
+        synchronized (stateLock) {
+            return !state.isRunning() && !state.inErrorState();

Review comment:
       Why not just `state.CREATED` as we are excluding three out of four states here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org