You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2026/06/14 22:39:47 UTC
[PR] [SPARK-57443][BUILD][FOLLOWUP] Add 4.3 MiMa excludes section to master [spark]
cloud-fan opened a new pull request, #56510:
URL: https://github.com/apache/spark/pull/56510
### What changes were proposed in this pull request?
Followup to #56503 ([SPARK-57443], which bumped `branch-4.x` to `4.3.0-SNAPSHOT` and added a `v43excludes` MiMa section there). This applies the matching change on `master`:
- add `v43excludes` (built from `v42excludes`);
- re-point `v50excludes` to build on `v43excludes` instead of `v42excludes`, so the exclude chain is `... -> v42excludes -> v43excludes -> v50excludes`;
- add the `case v if v.startsWith("4.3") => v43excludes` arm to `excludes(version)`.
### Why are the changes needed?
Now that `4.3.0` is a live version on `branch-4.x`, `master`'s `MimaExcludes` must know about it: the exclude chain should stay complete (5.0 builds on 4.3), and `excludes(version)` should resolve `4.3.x`. This also keeps `master` and `branch-4.x` consistent so backports apply cleanly. (Per the note on #56503.)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
N/A (build / MiMa configuration only).
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56740][BUILD][FOLLOWUP] Add 4.3 MiMa excludes section to master [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #56510:
URL: https://github.com/apache/spark/pull/56510#issuecomment-4704588226
thanks for the review, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56740][BUILD][FOLLOWUP] Add 4.3 MiMa excludes section to master [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #56510: [SPARK-56740][BUILD][FOLLOWUP] Add 4.3 MiMa excludes section to master
URL: https://github.com/apache/spark/pull/56510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56740][BUILD][FOLLOWUP] Add 4.3 MiMa excludes section to master [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #56510:
URL: https://github.com/apache/spark/pull/56510#issuecomment-4703310398
cc @HyukjinKwon @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org