You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/11 12:51:58 UTC

[jira] [Commented] (S2GRAPH-146) Merge two IndexEdgeDeserializable under tall, wide package into one.

    [ https://issues.apache.org/jira/browse/S2GRAPH-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15739698#comment-15739698 ] 

ASF GitHub Bot commented on S2GRAPH-146:
----------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/111

    [S2GRAPH-146]: Merge two IndexEdgeDeserializable under tall, wide package into one.

    - Merge two IndexEdgeDeserializable into one.
    - Merge two SnapshotEdgeDeserializable into one.
    - Deprecate V1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-146

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit abaa176061e21ed235521d65ca9942516ddd02fb
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-12-11T12:49:53Z

    [S2GRAPH-146]: Merge two IndexEdgeDeserializable under tall, wide package into one.
    - Merge two IndexEdgeDeserializable into one.
    - Merge two SnapshotEdgeDeserializable into one.
    - Deprecate V1.

----


> Merge two IndexEdgeDeserializable under tall, wide package into one.
> --------------------------------------------------------------------
>
>                 Key: S2GRAPH-146
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-146
>             Project: S2Graph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Currently we have two IndexEdgeDeserializable class both for tall/wide schema.
> I suggest to refactor these so we can just call one single IndexEdgeDeserializable without knowing which label we are traversing on. 
> Currently, caller should pass QueryParam which specify {{Label}} we are searching for, but to deal with *search for all available {{Label}}* get complicated with this restriction. If user want to fetch all edges stored, then things get complicated.
> It would be better to refactor {{Deserializable}} to be able to know which {{Label}} we are deserializing while deserialize {{KeyValue}} from storage rather than depending on parameter passed from caller. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)