You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2010/02/21 09:24:27 UTC
[jira] Created: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Fix RCFile resource leak when opening a non-RCFile
--------------------------------------------------
Key: HIVE-1185
URL: https://issues.apache.org/jira/browse/HIVE-1185
Project: Hadoop Hive
Issue Type: Bug
Reporter: Zheng Shao
Assignee: He Yongqiang
See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1185:
---------------------------------
Fix Version/s: (was: 0.5.0)
Component/s: Serializers/Deserializers
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Serializers/Deserializers
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.6.0
>
> Attachments: hive-1185.1.patch, hive-1185.2.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-1185:
-------------------------------
Attachment: hive-1185.1.patch
adopted the patch from hadoop-5476
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Attachments: hive-1185.1.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1185) Fix RCFile resource leak when opening
a non-RCFile
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836469#action_12836469 ]
Zheng Shao commented on HIVE-1185:
----------------------------------
+1. Will test and commit.
(Please do "Submit Patch" after you uploaded the patch file next time)
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.5.0, 0.6.0
>
> Attachments: hive-1185.1.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-1185:
-------------------------------
Attachment: hive-1185.2.patch
we need to close that stream no matter what the current hadoop version is. So i just closed that stream inside rcfile reader.
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.5.0, 0.6.0
>
> Attachments: hive-1185.1.patch, hive-1185.2.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1185:
-----------------------------
Status: Open (was: Patch Available)
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.5.0, 0.6.0
>
> Attachments: hive-1185.1.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1185:
-----------------------------
Fix Version/s: 0.6.0
0.5.0
Affects Version/s: 0.6.0
0.5.0
Status: Patch Available (was: Open)
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.5.0, 0.6.0
>
> Attachments: hive-1185.1.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1185) Fix RCFile resource leak when opening
a non-RCFile
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836471#action_12836471 ]
Zheng Shao commented on HIVE-1185:
----------------------------------
Unfortunately it does not compile with hadoop 0.17.
Can you add "IOUtils.cleanup" to shims?
{code}
[javac] Compiling 22 source files to /data/users/zshao/hadoop_hive_trunk/build/ql/classes
[javac] /data/users/zshao/hadoop_hive_trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java:988: cannot find symbol
[javac] symbol : method cleanup(org.apache.commons.logging.Log,org.apache.hadoop.fs.FSDataInputStream)
[javac] location: class org.apache.hadoop.io.IOUtils
[javac] IOUtils.cleanup(LOG, in);
{code}
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.5.0, 0.6.0
>
> Attachments: hive-1185.1.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1185:
---------------------------------
Affects Version/s: (was: 0.5.0)
This was not backported to 0.5.0.
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Serializers/Deserializers
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.6.0
>
> Attachments: hive-1185.1.patch, hive-1185.2.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1185:
---------------------------------
Affects Version/s: (was: 0.6.0)
Release Note: (was: HIVE-1185. Fix RCFile resource leak when opening a non-RCFile. (He Yongqiang via zshao)
)
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hive
> Issue Type: Bug
> Components: Serializers/Deserializers
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.6.0
>
> Attachments: hive-1185.1.patch, hive-1185.2.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1185:
-----------------------------
Tags: rcfile
Resolution: Fixed
Release Note:
HIVE-1185. Fix RCFile resource leak when opening a non-RCFile. (He Yongqiang via zshao)
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to both branch-0.5 and trunk. Thanks Yongqiang!
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.5.0, 0.6.0
>
> Attachments: hive-1185.1.patch, hive-1185.2.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1185) Fix RCFile resource leak when opening a
non-RCFile
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-1185:
-------------------------------
Status: Patch Available (was: Open)
> Fix RCFile resource leak when opening a non-RCFile
> --------------------------------------------------
>
> Key: HIVE-1185
> URL: https://issues.apache.org/jira/browse/HIVE-1185
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: He Yongqiang
> Fix For: 0.5.0, 0.6.0
>
> Attachments: hive-1185.1.patch, hive-1185.2.patch
>
>
> See HADOOP-5476 for the bug in SequenceFile. We should do the same thing in RCFile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.