[jira] [Commented] (CASSANDRA-3729) support counter debug mode on thrift interface

["Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184796#comment-13184796 ] 

Sylvain Lebresne commented on CASSANDRA-3729:
---------------------------------------------

I think the thrift interface is too user visible for something like this. Maybe a JMX method (in some debug MBean) would be less of a problem.

That being said, it's not really something we can ask people to turn on to help troubleshooting a problem they would have with counters as it would break counter reads. Logging contexts at debug in the log (which we more or less do, though maybe we can improve it a bit) seems more useful for that.

And if it's really just for the 4 of us developers working on counters, we can recompile the code with 1 line commented to get the same behavior if we so wish. So not sure I feel it's worth taking the chance that someone hit that trigger in production by accident.
                
> support counter debug mode on thrift interface
> ----------------------------------------------
>
>                 Key: CASSANDRA-3729
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3729
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>            Priority: Minor
>         Attachments: trunk-3729.txt
>
>
> Attaching a patch against trunk to add a counter debug mode on the thrift interface, allowing clients to decode and inspect counter contexts. This is all Stu's code, except that I generated the thrift stuff so any mistakes there are mine.
> This was extremely useful internally on an 0.8. The patch is not yet tested on trunk, but if you think this can go in I will spend effort to test it soonish.
> It's not very invasive (other than the generated thrift code), so it feels okay to have it if we maybe document that it is not a supported interface (clearly in the thrift spec).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira