[jira] Issue Comment Edited: (PIVOT-458) ListButton: show popup only on triangle click

["Dirk Moebius (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857419#action_12857419 ] 

Dirk Moebius edited comment on PIVOT-458 at 4/15/10 1:20 PM:
-------------------------------------------------------------

Here's the patch for MenuButton.

On second thought, I might need this behavior on both MenuButton and LinkButton in my application.

I'm opposed to "split" - this name doesn't seam to explain anything to me.

How about a reversed boolean "popupOnBodyClick": default true ?!? (Or: "popupOnLabel" ?)

      was (Author: dmoebius):
    Here's the patch for MenuButton.

On second thought, I might need this behavior on both MenuButton and LinkButton in my application.

I'm opposed to "split" - this name doesn't seam to explain anything to me.

How about a reversed boolean "popupOnBodyClick": default true ?!?
  
> ListButton: show popup only on triangle click
> ---------------------------------------------
>
>                 Key: PIVOT-458
>                 URL: https://issues.apache.org/jira/browse/PIVOT-458
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-terra
>            Reporter: Dirk Moebius
>            Priority: Minor
>         Attachments: listbutton-popup.patch, menubutton-popup.patch
>
>
> I found this to be a requirement in my application: if the user clicks the label part of a LinkButton, the button should fire immediately without showing the popup, thus invoking the action with the currently selected entry. If the user clicks the triangle part, the popup should be shown.
> I patched LinkButton to add a new boolean property called "showPopupOnTriggerClickOnly" to TerraListButtonSkin (I couldn't think of a better name, sorry). If set to true, the ListButton popup will only show up if the user clicks the triangle, but not if the user clicks the rest of the button. However, ButtonPressListeners fire as usual, if the user clicks any part of the button. If the property is false, the behavior is as it was before. The default value of the property is false.
> I tested the patch in my application and ComponentExplorer and it works good.
> It would be nice if you integrate the patch. Otherwise I'd still have the option to write a custom skin, but I think this patch could be interesting to other developers as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira