[flink-jira-bot] 30/47: [FLINK-22034] get rid of LOWER_PRIORITIES constant

[kn...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

knaufk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-jira-bot.git

commit 3fcb3fff062c80d08c22c816836d600155e009af
Author: Konstantin Knauf <kn...@gmail.com>
AuthorDate: Thu Apr 22 10:54:11 2021 +0200

    [FLINK-22034] get rid of LOWER_PRIORITIES constant
---
 flink_jira_bot.py            | 6 +++---
 stale_major_or_above_rule.py | 9 +++------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/flink_jira_bot.py b/flink_jira_bot.py
index aa1befa..36f8ca0 100644
--- a/flink_jira_bot.py
+++ b/flink_jira_bot.py
@@ -67,13 +67,13 @@ if __name__ == "__main__":
     )
     stale_minor_rule = StaleMinorRule(jira, jira_bot_config["stale_minor"], args.dryrun)
     stale_major_rule = StaleMajorOrAboveRule(
-        jira, jira_bot_config["stale_major"], args.dryrun, "Major"
+        jira, jira_bot_config["stale_major"], args.dryrun, "Major", "Minor"
     )
     stale_critical_rule = StaleMajorOrAboveRule(
-        jira, jira_bot_config["stale_critical"], args.dryrun, "Critical"
+        jira, jira_bot_config["stale_critical"], args.dryrun, "Critical", "Major"
     )
     stale_blocker_rule = StaleMajorOrAboveRule(
-        jira, jira_bot_config["stale_blocker"], args.dryrun, "Blocker"
+        jira, jira_bot_config["stale_blocker"], args.dryrun, "Blocker", "Critical"
     )
     stale_assigned_rule.run()
     stale_minor_rule.run()
diff --git a/stale_major_or_above_rule.py b/stale_major_or_above_rule.py
index d5e5663..c5509a0 100644
--- a/stale_major_or_above_rule.py
+++ b/stale_major_or_above_rule.py
@@ -16,8 +16,6 @@
 # limitations under the License.
 ################################################################################
 
-import logging
-
 from flink_jira_rule import FlinkJiraRule
 
 
@@ -31,12 +29,11 @@ class StaleMajorOrAboveRule(FlinkJiraRule):
     The time periods before warning differ based on the priority:
     """
 
-    def __init__(self, jira_client, config, is_dry_run, priority):
+    def __init__(self, jira_client, config, is_dry_run, priority, lower_priority):
         super().__init__(jira_client, config, is_dry_run)
+        self.lower_priority = lower_priority
         self.priority = priority
 
-    LOWER_PRIORITIES = {"Blocker": "Critical", "Critical": "Major", "Major": "Minor"}
-
     def run(self):
         self.handle_tickets_marked_stale(
             f"project=FLINK AND Priority = {self.priority} AND resolution = Unresolved "
@@ -49,4 +46,4 @@ class StaleMajorOrAboveRule(FlinkJiraRule):
         )
 
     def handle_stale_ticket(self, key):
-        self.set_priority(key, self.LOWER_PRIORITIES[self.priority])
+        self.set_priority(key, self.lower_priority)