You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Joey Echeverria (JIRA)" <ji...@apache.org> on 2012/05/30 16:37:23 UTC

[jira] [Created] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Joey Echeverria created HADOOP-8449:
---------------------------------------

             Summary: hadoop fs -text fails with compressed sequence files with the codec file extension
                 Key: HADOOP-8449
                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
             Project: Hadoop Common
          Issue Type: Bug
    Affects Versions: 2.0.0-alpha, 1.0.3
            Reporter: Joey Echeverria
            Priority: Minor


When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.

The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404501#comment-13404501 ] 

Hudson commented on HADOOP-8449:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1125 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1125/])
    HADOOP-8449. hadoop fs -text fails with compressed sequence files with the codec file extension. (harsh) (Revision 1355636)

     Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355636
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java

                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401750#comment-13401750 ] 

Joey Echeverria commented on HADOOP-8449:
-----------------------------------------

I think he means he ran the new tests without the fix to Display.java and it failed as expected, but passes with the patched Display.java as desired.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-8449:
----------------------------

    Attachment: HADOOP-8449.patch

Attached patch addresses Aaron and Daryn's comments. Added test bits fail without the Display.java changes, expectedly. Passes otherwise.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404397#comment-13404397 ] 

Hudson commented on HADOOP-8449:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2482 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2482/])
    HADOOP-8449. hadoop fs -text fails with compressed sequence files with the codec file extension. (harsh) (Revision 1355636)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355636
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java

                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404464#comment-13404464 ] 

Hudson commented on HADOOP-8449:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1092 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1092/])
    HADOOP-8449. hadoop fs -text fails with compressed sequence files with the codec file extension. (harsh) (Revision 1355636)

     Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355636
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java

                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286060#comment-13286060 ] 

Hadoop QA commented on HADOOP-8449:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530258/HADOOP-8449.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.viewfs.TestViewFsTrash
                  org.apache.hadoop.ha.TestZKFailoverController

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1059//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1059//console

This message is automatically generated.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-8449:
----------------------------

    Attachment: HADOOP-8449.patch

This patch ought to take care of this. The reverse order is what Hue does as well, as I remember from my https://issues.cloudera.org/browse/HUE-1 patch.

I could not find tests for this command (or others) so haven't added any.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Priority: Minor
>         Attachments: HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286133#comment-13286133 ] 

Joey Echeverria commented on HADOOP-8449:
-----------------------------------------

As Harsh pointed out, there are no tests for the FsShell commands. The two failing tests look unrelated, so I'm +1 on the patch.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-8449:
----------------------------

    Status: Patch Available  (was: Open)
    
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha, 1.0.3
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J reassigned HADOOP-8449:
-------------------------------

    Assignee: Harsh J
    
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460239#comment-13460239 ] 

Harsh J commented on HADOOP-8449:
---------------------------------

Thanks Muddy, silly mistake of mine. I filed https://issues.apache.org/jira/browse/HADOOP-8833
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.2-alpha
>
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Muddy Dixon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459352#comment-13459352 ] 

Muddy Dixon commented on HADOOP-8449:
-------------------------------------

Hi

We found the changes in order of switch and guard block in 

{code}private InputStream forMagic(Path p, FileSystem srcFs) throws IOException{code}

Because of this change, return value of {code}codec.createInputStream(i){code} is changed if codec exists.

h4. cdh3u3
{code}
private InputStream forMagic(Path p, FileSystem srcFs) throws IOException {
    FSDataInputStream i = srcFs.open(p);

    // check codecs
    CompressionCodecFactory cf = new CompressionCodecFactory(getConf());
    CompressionCodec codec = cf.getCodec(p);
    if (codec != null) {
      return codec.createInputStream(i);
    }

    switch(i.readShort()) {
       // cases
    }
{code}


h4. cdh3u5
{code}
private InputStream forMagic(Path p, FileSystem srcFs) throws IOException {
    FSDataInputStream i = srcFs.open(p);

    switch(i.readShort()) { // <=== index (or pointer) processes!!
      // cases
      default: {
        // Check the type of compression instead, depending on Codec class's
        // own detection methods, based on the provided path.
        CompressionCodecFactory cf = new CompressionCodecFactory(getConf());
        CompressionCodec codec = cf.getCodec(p);
        if (codec != null) {
          return codec.createInputStream(i);
        }
        break;
      }
    }

    // File is non-compressed, or not a file container we know.
    i.seek(0);
    return i;
  }
{code}
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.2-alpha
>
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401691#comment-13401691 ] 

Daryn Sharp commented on HADOOP-8449:
-------------------------------------

Which {{Display}} changes are you referring to?
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404398#comment-13404398 ] 

Hudson commented on HADOOP-8449:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2414 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2414/])
    HADOOP-8449. hadoop fs -text fails with compressed sequence files with the codec file extension. (harsh) (Revision 1355636)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355636
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java

                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404408#comment-13404408 ] 

Hudson commented on HADOOP-8449:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2431 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2431/])
    HADOOP-8449. hadoop fs -text fails with compressed sequence files with the codec file extension. (harsh) (Revision 1355636)

     Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355636
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java

                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286731#comment-13286731 ] 

Aaron T. Myers commented on HADOOP-8449:
----------------------------------------

bq. Please link the hdfs jira to this one.

I don't think there's a need for a separate JIRA, now that test-patch.sh supports cross-project patches.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402248#comment-13402248 ] 

Daryn Sharp commented on HADOOP-8449:
-------------------------------------

+1
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-8449:
----------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.1-alpha
    Target Version/s:   (was: 2.0.1-alpha, 3.0.0)
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

Thank you Daryn. Committed to branch-2 and trunk.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.1-alpha
>
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286188#comment-13286188 ] 

Aaron T. Myers commented on HADOOP-8449:
----------------------------------------

bq. there are no tests for the FsShell commands.

There are many tests for the shell commands, but they're unfortunately in the HDFS sub-project, even though FsShell is implemented in Common. See: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401696#comment-13401696 ] 

Hadoop QA commented on HADOOP-8449:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12533528/HADOOP-8449.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.fs.viewfs.TestViewFsTrash
                  org.apache.hadoop.hdfs.TestDatanodeBlockScanner

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1141//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1141//console

This message is automatically generated.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-8449:
----------------------------

    Target Version/s: 3.0.0
              Status: Patch Available  (was: Open)
    
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha, 1.0.3
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286615#comment-13286615 ] 

Daryn Sharp commented on HADOOP-8449:
-------------------------------------

Please link the hdfs jira to this one.  Pending tests, I think this looks good.  One trivial suggestion would be to move the codec stuff into a default case for the switch.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-8449:
----------------------------

    Target Version/s: 2.0.1-alpha, 3.0.0  (was: 3.0.0)

The javadocs are from MAPREDUCE-4355 and will be addressed from its follow ups.

Thanks Aaron, Daryn and Joey! Committing by EOD to trunk and branch-2 unless there's any other comment.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Joey Echeverria (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285850#comment-13285850 ] 

Joey Echeverria commented on HADOOP-8449:
-----------------------------------------

Yup. I'm cool with using extensions, but after we check for SEQ. Today, it's reversed. It checks the extension before checking for the magic header.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Priority: Minor
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed HADOOP-8449.
---------------------------------

    
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 2.0.2-alpha
>
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401766#comment-13401766 ] 

Daryn Sharp commented on HADOOP-8449:
-------------------------------------

Looks good, please check if the javadoc warnings are related.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch, HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-8449:
----------------------------

    Status: Open  (was: Patch Available)

Thanks ATM. Totally missed that class. I'll improve the Text test in it to catch regressions in future, and provide a new patch. Cancelling current patch.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha, 1.0.3
>            Reporter: Joey Echeverria
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-8449.patch
>
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8449) hadoop fs -text fails with compressed sequence files with the codec file extension

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285845#comment-13285845 ] 

Harsh J commented on HADOOP-8449:
---------------------------------

Snappy is currently un-detectable code wise, at least AFAICT, since it lacks a container format. However, yeah, we should check for SEQ magic header (and the likes) first I think.
                
> hadoop fs -text fails with compressed sequence files with the codec file extension
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8449
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Joey Echeverria
>            Priority: Minor
>
> When the -text command is run on a file and the file ends in the default extension for a codec (e.g. snappy or gz), but is a compressed sequence file, the command will fail.
> The issue is that it assumes that if it matches the extension, then it's plain compressed file. It might be more helpful to check if it's a sequence file first, and then check the file extension second.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira