You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2014/03/19 11:51:50 UTC

[GitHub] cordova-cli pull request: Splash screen support via config.xml for...

GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-cli/pull/145

    Splash screen support via config.xml for WP8 and Windows8

    https://issues.apache.org/jira/browse/CB-6308
    https://issues.apache.org/jira/browse/CB-6309
    Adds support of 'SplashScreen' preference for WP8 and Windows8.
    
        <preference name="SplashScreen" value="SpashScreenImage-Default.jpg"/>
        <platform name="wp8">
            <preference name="SplashScreen" value="assets\SplashScreenImage-WP8.jpg"/>
        </platform>
        <platform name="windows8">
            <preference name="SplashScreen" value="assets\SplashScreenImage-Windows8.png"/>
        </platform>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgrebnov/cordova-cli splash-screen-windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #145
    
----
commit 0d523ca248be500ebaa8db8c30d99292c30b31d2
Author: sgrebnov <se...@gmail.com>
Date:   2014-03-19T09:27:57Z

    CB-6308 WP8. Add Splash Screen img support via config.xml preference

commit 5b6c63da70e6b6aa4fdc83ecca49b84a21ea6257
Author: sgrebnov <se...@gmail.com>
Date:   2014-03-19T10:48:38Z

    CB-6309 Windows8. Add Splash Screen img support via config.xml preference

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-cli pull request: Splash screen support via config.xml for...

Posted by sgrebnov <gi...@git.apache.org>.

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-cli/pull/145#issuecomment-49213174
  
    Not valid anymore, closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-cli pull request: Splash screen support via config.xml for...

Posted by purplecabbage <gi...@git.apache.org>.

Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-cli/pull/145#issuecomment-38506992
  
    This needs to be handled in the platform repo, projects can be built outside of the cordova-cli and if the property is in the application root config.xml it should always be valid.
    This should be resolved at runtime.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-cli pull request: Splash screen support via config.xml for...

Posted by sgrebnov <gi...@git.apache.org>.

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-cli/pull/145#issuecomment-38566101
  
    I'm not sure it could be resolved in runtime since the app will show default splash screen before we can change anything. So there are three options here:
    1. Move logic above to platform specific build script, in this case developer will be able to apply config changes via cordova/build.bat
    2. Same as above but use separate script and corresponding pre-build event. In this case changes will be applied any time we run msbuild (from VS, from CLI, via cordova/build.bat)
    3. Remove default splash screen image and proceed with splash screen plugin only. It will be able get/apply image from config.xml. 
    
    @purplecabbage/Jesse, your thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-cli pull request: Splash screen support via config.xml for...

Posted by sgrebnov <gi...@git.apache.org>.

Github user sgrebnov closed the pull request at:

    https://github.com/apache/cordova-cli/pull/145


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---