You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/27 20:59:49 UTC

[GitHub] [solr] risdenk opened a new pull request, #1142: SOLR-16500: Enable JDK 19 preview options for MMapDirectory V2

risdenk opened a new pull request, #1142:
URL: https://github.com/apache/solr/pull/1142

   https://issues.apache.org/jira/browse/SOLR-16500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] risdenk commented on pull request #1142: SOLR-16500: Added --enable-preview for JDK 19 to enable MemorySegment support in MMapDirectory

Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1142:
URL: https://github.com/apache/solr/pull/1142#issuecomment-1295133564

   Addressed wording in 346c884


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] risdenk commented on pull request #1142: SOLR-16500: Enable JDK 19 preview options for MMapDirectory V2

Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1142:
URL: https://github.com/apache/solr/pull/1142#issuecomment-1295088837

   > I am not sure if "MMapDirectory V2" is a good term to describe it in the message. Maybe remove the message at all. Because Lucene logs a message anyways.
   
   so I want to at least leave a message that we enabled preview features and that we added a flag to the JDK. I'm open to calling it something other than `MMapDirectory V2`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] risdenk merged pull request #1142: SOLR-16500: Added --enable-preview for JDK 19 to enable MemorySegment support in MMapDirectory

Posted by GitBox <gi...@apache.org>.
risdenk merged PR #1142:
URL: https://github.com/apache/solr/pull/1142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] uschindler commented on pull request #1142: SOLR-16500: Enable JDK 19 preview options for MMapDirectory V2

Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #1142:
URL: https://github.com/apache/solr/pull/1142#issuecomment-1295115394

   > > I am not sure if "MMapDirectory V2" is a good term to describe it in the message. Maybe remove the message at all. Because Lucene logs a message anyways.
   > 
   > so I want to at least leave a message that we enabled preview features and that we added a flag to the JDK. I'm open to calling it something other than `MMapDirectory V2`.
   
   Maybe call it "Java $JAVA_VER_NUM detected. Added --enable-preview to enable MemorySegment support in MMapDirectory. See SOLR-16500"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org