You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/29 02:00:10 UTC
[GitHub] [spark] dcoliversun commented on a diff in pull request #36433: [SPARK-36462][K8S] Add the ability to selectively disable watching or polling
dcoliversun commented on code in PR #36433:
URL: https://github.com/apache/spark/pull/36433#discussion_r909132128
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -479,6 +479,25 @@ private[spark] object Config extends Logging {
.checkValue(interval => interval > 0, s"Logging interval must be a positive time value.")
.createWithDefaultString("1s")
+ val KUBERNETES_EXECUTOR_ENABLE_API_POLLING =
+ ConfigBuilder("spark.kubernetes.executor.enableApiPolling")
+ .doc("If Spark should poll Kubernetes for executor pod status. " +
+ "You should leave this enabled unless you're encountering issues with your etcd.")
+ .version("3.4.0")
+ .booleanConf
+ .internal()
Review Comment:
Maybe it works.
```suggestion
.internal()
.booleanConf
```
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -479,6 +479,25 @@ private[spark] object Config extends Logging {
.checkValue(interval => interval > 0, s"Logging interval must be a positive time value.")
.createWithDefaultString("1s")
+ val KUBERNETES_EXECUTOR_ENABLE_API_POLLING =
+ ConfigBuilder("spark.kubernetes.executor.enableApiPolling")
+ .doc("If Spark should poll Kubernetes for executor pod status. " +
+ "You should leave this enabled unless you're encountering issues with your etcd.")
+ .version("3.4.0")
+ .booleanConf
+ .internal()
+ .createWithDefault(true)
+
+ val KUBERNETES_EXECUTOR_ENABLE_API_WATCHER =
+ ConfigBuilder("spark.kubernetes.executor.enableApiWatcher")
+ .doc("If Spark should create watchers for executor pod status. " +
+ "You should leave this enabled unless you're encountering issues with your etcd.")
+ .version("3.4.0")
+ .booleanConf
+ .internal()
Review Comment:
ditto
```suggestion
.internal()
.booleanConf
```
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -479,6 +479,25 @@ private[spark] object Config extends Logging {
.checkValue(interval => interval > 0, s"Logging interval must be a positive time value.")
.createWithDefaultString("1s")
+ val KUBERNETES_EXECUTOR_ENABLE_API_POLLING =
+ ConfigBuilder("spark.kubernetes.executor.enableApiPolling")
+ .doc("If Spark should poll Kubernetes for executor pod status. " +
+ "You should leave this enabled unless you're encountering issues with your etcd.")
+ .version("3.4.0")
+ .booleanConf
+ .internal()
Review Comment:
GA failed.
```plain
[error] /home/runner/work/spark/spark/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:488:8: value internal is not a member of org.apache.spark.internal.config.TypedConfigBuilder[Boolean]
[error] possible cause: maybe a semicolon is missing before `value internal'?
[error] .internal()
[error] ^
[error] /home/runner/work/spark/spark/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:497:8: value internal is not a member of org.apache.spark.internal.config.TypedConfigBuilder[Boolean]
[error] possible cause: maybe a semicolon is missing before `value internal'?
[error] .internal()
[error] ^
[error] two errors found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org