[GitHub] [bookkeeper] gaozhangmin commented on a change in pull request #2778: Ledger replicate supports throttle

[GitBox <gi...@apache.org>]

gaozhangmin commented on a change in pull request #2778:
URL: https://github.com/apache/bookkeeper/pull/2778#discussion_r699799574



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
##########
@@ -154,11 +154,18 @@ public BookKeeperAdmin(String zkServers) throws IOException, InterruptedExceptio
      *             Throws this exception if there is an error instantiating the
      *             BookKeeper client.
      */
+    public BookKeeperAdmin(ClientConfiguration conf, ServerConfiguration serverConf) throws IOException, InterruptedException, BKException {
+        // Create the BookKeeper client instance
+        bkc = new BookKeeper(conf);
+        ownsBK = true;
+        this.lfr = new LedgerFragmentReplicator(bkc, NullStatsLogger.INSTANCE, serverConf);

Review comment:
       I saw BookkeeperAdmin would be used by external, like pulsar. I don't know If I change the constructor, it may have affect




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org