[jira] [Commented] (GEODE-8337) Rename Version enum to KnownVersion; VersionOrdinal to Version

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153149#comment-17153149 ] 

ASF GitHub Bot commented on GEODE-8337:
---------------------------------------

Bill opened a new pull request #5353:
URL: https://github.com/apache/geode/pull/5353


   [GEODE-8337](https://issues.apache.org/jira/browse/GEODE-8337)
   
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Rename Version enum to KnownVersion; VersionOrdinal to Version
> --------------------------------------------------------------
>
>                 Key: GEODE-8337
>                 URL: https://issues.apache.org/jira/browse/GEODE-8337
>             Project: Geode
>          Issue Type: Improvement
>          Components: serialization
>            Reporter: Bill Burcham
>            Assignee: Bill Burcham
>            Priority: Major
>         Attachments: screenshot-1.png, screenshot-2.png
>
>
> As a follow-on to GEODE-8240 and GEODE-8330, this is the final ticket, to rename:
> {{Version}} -> {{KnownVersion}}
> {{VersionOrdinal}} -> {{Version}}
> With this ticket, the work started in GEODE-8240 is complete.
> After this change, the versioning hierarchy will be:
>  !screenshot-1.png! 
> Before this change, the hierarchy was:
>  !screenshot-2.png! 
> As part of this story we'll also harmonize version access methods on MemberIdentifier, InternalDistributedMember, and GMSMemberData:
> getVersionOrdinalObject() becomes getVersion()
> On GMSMemberData:
> setVersionObjectForTest() becomes setVersionForTest()



--
This message was sent by Atlassian Jira
(v8.3.4#803005)