You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/06/23 21:28:51 UTC
[kudu-CR] alter schema transaction: don't crash in ToString() when no timestamp
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3475
to review the following change.
Change subject: alter_schema_transaction: don't crash in ToString() when no timestamp
......................................................................
alter_schema_transaction: don't crash in ToString() when no timestamp
Saw this in a local alter_table-test failure.
I0623 14:17:50.224598 26418 transaction_tracker.cc:230] Dumping currently running transactions:
F0623 14:17:50.224697 26418 transaction.h:206] Check failed: timestamp_ != Timestamp::kInvalidTimestamp
*** Check failure stack trace: ***
@ 0x7f4bb399146d google::LogMessage::Fail() at ??:0
@ 0x7f4bb39934d3 google::LogMessage::SendToLog() at ??:0
@ 0x7f4bb3990fca google::LogMessage::Flush() at ??:0
@ 0x7f4bb3993f1f google::LogMessageFatal::~LogMessageFatal() at ??:0
@ 0x7f4bb484e3f6 kudu::tablet::TransactionState::timestamp() at ??:0
@ 0x7f4bb489b804 kudu::tablet::AlterSchemaTransactionState::ToString() at ??:0
@ 0x7f4bb489c8f6 kudu::tablet::AlterSchemaTransaction::ToString() at ??:0
@ 0x7f4bb489f1fd kudu::tablet::TransactionDriver::ToStringUnlocked() at ??:0
@ 0x7f4bb489f132 kudu::tablet::TransactionDriver::ToString() at ??:0
@ 0x7f4bb48a6790 kudu::tablet::TransactionTracker::WaitForAllToFinish() at ??:0
@ 0x7f4bb48a612c kudu::tablet::TransactionTracker::WaitForAllToFinish() at ??:0
@ 0x7f4bb4891100 kudu::tablet::TabletPeer::Shutdown() at ??:0
@ 0x7f4bb4bfc993 kudu::tserver::TSTabletManager::Shutdown() at ??:0
@ 0x7f4bb4bd11a2 kudu::tserver::TabletServer::Shutdown() at ??:0
@ 0x7f4bb4b97e71 kudu::tserver::MiniTabletServer::Shutdown() at ??:0
@ 0x7f4bb4b97f8c kudu::tserver::MiniTabletServer::Restart() at ??:0
@ 0x447c10 kudu::AlterTableTest::RestartTabletServer() at /home/adar/Source/kudu/src/kudu/integration-tests/alter_table-test.cc:159
@ 0x4312e3 kudu::AlterTableTest_TestRestartTSDuringAlter_Test::TestBody() at /home/adar/Source/kudu/src/kudu/integration-tests/alter_table-test.cc:394 (discriminator 2)
@ 0x7f4bb4ebf0f7 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7f4bb4eb5f92 testing::Test::Run() at ??:0
@ 0x7f4bb4eb60d8 testing::TestInfo::Run() at ??:0
@ 0x7f4bb4eb61b5 testing::TestCase::Run() at ??:0
@ 0x7f4bb4eb6be8 testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7f4bb4ebf667 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7f4bb4eb628d testing::UnitTest::Run() at ??:0
@ 0x7f4bb4f6e226 RUN_ALL_TESTS() at ??:0
@ 0x7f4bb4f6dc89 main at ??:0
@ 0x7f4bb2a02830 __libc_start_main at ??:0
@ 0x42c689 _start at ??:?
@ (nil) (unknown)
Change-Id: I702aa5437dec54b93a78c9415d83be0d7d07c364
---
M src/kudu/tablet/transactions/alter_schema_transaction.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/3475/1
--
To view, visit http://gerrit.cloudera.org:8080/3475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I702aa5437dec54b93a78c9415d83be0d7d07c364
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] alter schema transaction: don't crash in ToString() when no timestamp
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: alter_schema_transaction: don't crash in ToString() when no timestamp
......................................................................
alter_schema_transaction: don't crash in ToString() when no timestamp
Saw this in a local alter_table-test failure.
I0623 14:17:50.224598 26418 transaction_tracker.cc:230] Dumping currently running transactions:
F0623 14:17:50.224697 26418 transaction.h:206] Check failed: timestamp_ != Timestamp::kInvalidTimestamp
*** Check failure stack trace: ***
@ 0x7f4bb399146d google::LogMessage::Fail() at ??:0
@ 0x7f4bb39934d3 google::LogMessage::SendToLog() at ??:0
@ 0x7f4bb3990fca google::LogMessage::Flush() at ??:0
@ 0x7f4bb3993f1f google::LogMessageFatal::~LogMessageFatal() at ??:0
@ 0x7f4bb484e3f6 kudu::tablet::TransactionState::timestamp() at ??:0
@ 0x7f4bb489b804 kudu::tablet::AlterSchemaTransactionState::ToString() at ??:0
@ 0x7f4bb489c8f6 kudu::tablet::AlterSchemaTransaction::ToString() at ??:0
@ 0x7f4bb489f1fd kudu::tablet::TransactionDriver::ToStringUnlocked() at ??:0
@ 0x7f4bb489f132 kudu::tablet::TransactionDriver::ToString() at ??:0
@ 0x7f4bb48a6790 kudu::tablet::TransactionTracker::WaitForAllToFinish() at ??:0
@ 0x7f4bb48a612c kudu::tablet::TransactionTracker::WaitForAllToFinish() at ??:0
@ 0x7f4bb4891100 kudu::tablet::TabletPeer::Shutdown() at ??:0
@ 0x7f4bb4bfc993 kudu::tserver::TSTabletManager::Shutdown() at ??:0
@ 0x7f4bb4bd11a2 kudu::tserver::TabletServer::Shutdown() at ??:0
@ 0x7f4bb4b97e71 kudu::tserver::MiniTabletServer::Shutdown() at ??:0
@ 0x7f4bb4b97f8c kudu::tserver::MiniTabletServer::Restart() at ??:0
@ 0x447c10 kudu::AlterTableTest::RestartTabletServer() at /home/adar/Source/kudu/src/kudu/integration-tests/alter_table-test.cc:159
@ 0x4312e3 kudu::AlterTableTest_TestRestartTSDuringAlter_Test::TestBody() at /home/adar/Source/kudu/src/kudu/integration-tests/alter_table-test.cc:394 (discriminator 2)
@ 0x7f4bb4ebf0f7 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7f4bb4eb5f92 testing::Test::Run() at ??:0
@ 0x7f4bb4eb60d8 testing::TestInfo::Run() at ??:0
@ 0x7f4bb4eb61b5 testing::TestCase::Run() at ??:0
@ 0x7f4bb4eb6be8 testing::internal::UnitTestImpl::RunAllTests() at ??:0
@ 0x7f4bb4ebf667 testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0
@ 0x7f4bb4eb628d testing::UnitTest::Run() at ??:0
@ 0x7f4bb4f6e226 RUN_ALL_TESTS() at ??:0
@ 0x7f4bb4f6dc89 main at ??:0
@ 0x7f4bb2a02830 __libc_start_main at ??:0
@ 0x42c689 _start at ??:?
@ (nil) (unknown)
Change-Id: I702aa5437dec54b93a78c9415d83be0d7d07c364
Reviewed-on: http://gerrit.cloudera.org:8080/3475
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/transactions/alter_schema_transaction.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I702aa5437dec54b93a78c9415d83be0d7d07c364
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] alter schema transaction: don't crash in ToString() when no timestamp
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: alter_schema_transaction: don't crash in ToString() when no timestamp
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/1972/
--
To view, visit http://gerrit.cloudera.org:8080/3475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I702aa5437dec54b93a78c9415d83be0d7d07c364
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] alter schema transaction: don't crash in ToString() when no timestamp
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: alter_schema_transaction: don't crash in ToString() when no timestamp
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I702aa5437dec54b93a78c9415d83be0d7d07c364
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No