You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gustavo Nery <gu...@gmail.com> on 2014/05/14 16:33:52 UTC
Review Request 21435: Fix for
https://issues.apache.org/jira/browse/CLOUDSTACK-6610
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21435/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
The HypervisorTemplateAdapter are publishing the event on event bus sending the enityType and entityUUID as null. Without this informations, the listener on event bus cant get the template that was deleted.
Just modified the HypervisorTemplateAdapter.java to pass the right params to the UsageEventUtils publishUsageEvent method.
Diffs
-----
server/src/com/cloud/template/HypervisorTemplateAdapter.java 71eac66
Diff: https://reviews.apache.org/r/21435/diff/
Testing
-------
Thanks,
Gustavo Nery
Re: Review Request 21435: Fix for
https://issues.apache.org/jira/browse/CLOUDSTACK-6610
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21435/#review80438
-----------------------------------------------------------
Ship it!
testing, discard
- Sebastien Goasguen
On May 14, 2014, 2:33 p.m., Gustavo Nery wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21435/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 2:33 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The HypervisorTemplateAdapter are publishing the event on event bus sending the enityType and entityUUID as null. Without this informations, the listener on event bus cant get the template that was deleted.
>
> Just modified the HypervisorTemplateAdapter.java to pass the right params to the UsageEventUtils publishUsageEvent method.
>
>
> Diffs
> -----
>
> server/src/com/cloud/template/HypervisorTemplateAdapter.java 71eac66
>
> Diff: https://reviews.apache.org/r/21435/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gustavo Nery
>
>
Re: Review Request 21435: Fix for
https://issues.apache.org/jira/browse/CLOUDSTACK-6610
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21435/#review79048
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On May 14, 2014, 2:33 p.m., Gustavo Nery wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21435/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 2:33 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The HypervisorTemplateAdapter are publishing the event on event bus sending the enityType and entityUUID as null. Without this informations, the listener on event bus cant get the template that was deleted.
>
> Just modified the HypervisorTemplateAdapter.java to pass the right params to the UsageEventUtils publishUsageEvent method.
>
>
> Diffs
> -----
>
> server/src/com/cloud/template/HypervisorTemplateAdapter.java 71eac66
>
> Diff: https://reviews.apache.org/r/21435/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gustavo Nery
>
>