You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/12/05 14:45:50 UTC
Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-8549
https://issues.apache.org/jira/browse/AMBARI-8549
Repository: ambari
Description
-------
for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
Diff: https://reviews.apache.org/r/28753/diff/
Testing
-------
Manual testing.
Patch still is under development
Thanks,
Dmitro Lisnichenko
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/#review64010
-----------------------------------------------------------
Ship it!
Looks good, just have Alejandro double confirm.
- Nate Cole
On Dec. 5, 2014, 10:18 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28753/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 10:18 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8549
> https://issues.apache.org/jira/browse/AMBARI-8549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
>
> Diff: https://reviews.apache.org/r/28753/diff/
>
>
> Testing
> -------
>
> Manual testing.
> Patch still is under development
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, line 373
> > <https://reviews.apache.org/r/28753/diff/3/?file=783802#file783802line373>
> >
> > The initial state should be UPGRADING since a stack version cannot jump directly into INSTALLED.
> >
> > If the UI is using INSTALLED as a way to create dummy data, I suggest folks insert the data manually through the DB so that this code can lock-down.
>
> Dmitro Lisnichenko wrote:
> It has been done to help UI folks.
> Also, according to current design, new cluster stack version should be in INIT state.
>
> Alejandro Fernandez wrote:
> I just commented on the design doc. We can discuss the states since I believe that page 11 of the doc used them as an example of the endpoint and not as an exhaustive definition of what they were. In my opinion, only CURRENT, INSTALLING, should be init states.
> Exactly one stack version must be in a CURRENT state at all times. A new stack version should transition from INSTALLING->INSTALLED as part of the repo distribution and yum install, then followed by the actual rolling upgrade through UPGRADING->UPGRADED, and once the user confirms the entire operation, transition to CURRENT.
>
> Dmitro Lisnichenko wrote:
> Makes sense. May we commit the current patch to have the working UI for now? I've created a separate jira for implementing INSTALLING->INSTALLED transition.
Certainly
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/#review64038
-----------------------------------------------------------
On Dec. 8, 2014, 6:11 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28753/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 6:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8549
> https://issues.apache.org/jira/browse/AMBARI-8549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
>
> Diff: https://reviews.apache.org/r/28753/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.225s]
> [INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.468s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:40.036s
> [INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
> [INFO] Final Memory: 33M/323M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, line 373
> > <https://reviews.apache.org/r/28753/diff/3/?file=783802#file783802line373>
> >
> > The initial state should be UPGRADING since a stack version cannot jump directly into INSTALLED.
> >
> > If the UI is using INSTALLED as a way to create dummy data, I suggest folks insert the data manually through the DB so that this code can lock-down.
>
> Dmitro Lisnichenko wrote:
> It has been done to help UI folks.
> Also, according to current design, new cluster stack version should be in INIT state.
>
> Alejandro Fernandez wrote:
> I just commented on the design doc. We can discuss the states since I believe that page 11 of the doc used them as an example of the endpoint and not as an exhaustive definition of what they were. In my opinion, only CURRENT, INSTALLING, should be init states.
> Exactly one stack version must be in a CURRENT state at all times. A new stack version should transition from INSTALLING->INSTALLED as part of the repo distribution and yum install, then followed by the actual rolling upgrade through UPGRADING->UPGRADED, and once the user confirms the entire operation, transition to CURRENT.
Makes sense. May we commit the current patch to have the working UI for now? I've created a separate jira for implementing INSTALLING->INSTALLED transition.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/#review64038
-----------------------------------------------------------
On Dec. 8, 2014, 6:11 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28753/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 6:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8549
> https://issues.apache.org/jira/browse/AMBARI-8549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
>
> Diff: https://reviews.apache.org/r/28753/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.225s]
> [INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.468s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:40.036s
> [INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
> [INFO] Final Memory: 33M/323M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, line 373
> > <https://reviews.apache.org/r/28753/diff/3/?file=783802#file783802line373>
> >
> > The initial state should be UPGRADING since a stack version cannot jump directly into INSTALLED.
> >
> > If the UI is using INSTALLED as a way to create dummy data, I suggest folks insert the data manually through the DB so that this code can lock-down.
>
> Dmitro Lisnichenko wrote:
> It has been done to help UI folks.
> Also, according to current design, new cluster stack version should be in INIT state.
I just commented on the design doc. We can discuss the states since I believe that page 11 of the doc used them as an example of the endpoint and not as an exhaustive definition of what they were. In my opinion, only CURRENT, INSTALLING, should be init states.
Exactly one stack version must be in a CURRENT state at all times. A new stack version should transition from INSTALLING->INSTALLED as part of the repo distribution and yum install, then followed by the actual rolling upgrade through UPGRADING->UPGRADED, and once the user confirms the entire operation, transition to CURRENT.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/#review64038
-----------------------------------------------------------
On Dec. 8, 2014, 6:11 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28753/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 6:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8549
> https://issues.apache.org/jira/browse/AMBARI-8549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
>
> Diff: https://reviews.apache.org/r/28753/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.225s]
> [INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.468s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:40.036s
> [INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
> [INFO] Final Memory: 33M/323M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, line 373
> > <https://reviews.apache.org/r/28753/diff/3/?file=783802#file783802line373>
> >
> > The initial state should be UPGRADING since a stack version cannot jump directly into INSTALLED.
> >
> > If the UI is using INSTALLED as a way to create dummy data, I suggest folks insert the data manually through the DB so that this code can lock-down.
>
> Dmitro Lisnichenko wrote:
> It has been done to help UI folks.
> Also, according to current design, new cluster stack version should be in INIT state.
>
> Alejandro Fernandez wrote:
> I just commented on the design doc. We can discuss the states since I believe that page 11 of the doc used them as an example of the endpoint and not as an exhaustive definition of what they were. In my opinion, only CURRENT, INSTALLING, should be init states.
> Exactly one stack version must be in a CURRENT state at all times. A new stack version should transition from INSTALLING->INSTALLED as part of the repo distribution and yum install, then followed by the actual rolling upgrade through UPGRADING->UPGRADED, and once the user confirms the entire operation, transition to CURRENT.
>
> Dmitro Lisnichenko wrote:
> Makes sense. May we commit the current patch to have the working UI for now? I've created a separate jira for implementing INSTALLING->INSTALLED transition.
>
> Alejandro Fernandez wrote:
> Certainly
thank you
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/#review64038
-----------------------------------------------------------
On Dec. 8, 2014, 6:11 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28753/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 6:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8549
> https://issues.apache.org/jira/browse/AMBARI-8549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
>
> Diff: https://reviews.apache.org/r/28753/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.225s]
> [INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.468s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:40.036s
> [INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
> [INFO] Final Memory: 33M/323M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, line 373
> > <https://reviews.apache.org/r/28753/diff/3/?file=783802#file783802line373>
> >
> > The initial state should instead be UPGRADING.
As of now, we have no means to handle successful command report after installing packages/repositories, so we have no trigger to transition UPGRADING to INSTALLED state. To allow UI team to implement end to end process (with few skipped steps), for now we don't follow custom action status and create cluster repo version in already in INSTALLED state. I'll change it to INIT in next patches.
Also, UPGRADING is not valid value right after cluster stack version creation. We have a UI requirement that creation of cluster stack version does not trigger immediate installation of packages/repositories. That should be a separate request (PUT).
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, line 204
> > <https://reviews.apache.org/r/28753/diff/3/?file=783802#file783802line204>
> >
> > The bootstrap should now create a repo version.
> > e.g., stack is HDP-2.2 and repository_version is 2.2
> >
> > So the exception handling is not needed.
At least on trunk build I tested, after bootstrap we had cluster stack version with stack "HDP" and (repo) version "2.2". It did not match any repository version. I'll double-check that and remove this handling if it is not needed anymore.
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, line 204
> > <https://reviews.apache.org/r/28753/diff/3/?file=783802#file783802line204>
> >
> > This can now be removed since bootstrapping inserts a RepositoryVersion, e.g., stack is HDP-2.2 and version is 2.2
At least on trunk build I tested, after bootstrap we had cluster stack version with stack "HDP" and (repo) version "2.2". It did not match any repository version. I'll double-check that and remove this handling if it is not needed anymore.
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, line 373
> > <https://reviews.apache.org/r/28753/diff/3/?file=783802#file783802line373>
> >
> > The initial state should be UPGRADING since a stack version cannot jump directly into INSTALLED.
> >
> > If the UI is using INSTALLED as a way to create dummy data, I suggest folks insert the data manually through the DB so that this code can lock-down.
It has been done to help UI folks.
Also, according to current design, new cluster stack version should be in INIT state.
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java, line 213
> > <https://reviews.apache.org/r/28753/diff/3/?file=783803#file783803line213>
> >
> > Not needed any longer.
Please see the comment above
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java, line 213
> > <https://reviews.apache.org/r/28753/diff/3/?file=783803#file783803line213>
> >
> > Can now remove the exception handling.
Please see the comment above
> On Dec. 5, 2014, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, line 1213
> > <https://reviews.apache.org/r/28753/diff/3/?file=783806#file783806line1213>
> >
> > Again, INSTALLED should not be an acceptable start state.
Please see the comment above
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/#review64038
-----------------------------------------------------------
On Dec. 5, 2014, 5:35 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28753/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 5:35 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8549
> https://issues.apache.org/jira/browse/AMBARI-8549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
>
> Diff: https://reviews.apache.org/r/28753/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.225s]
> [INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.468s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:40.036s
> [INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
> [INFO] Final Memory: 33M/323M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/#review64038
-----------------------------------------------------------
I have concerns with why INSTALLED should be an allowed ClusterVersion and HostVersion state. I believe they should only be CURRENT and UPGRADING.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
<https://reviews.apache.org/r/28753/#comment106421>
The bootstrap should now create a repo version.
e.g., stack is HDP-2.2 and repository_version is 2.2
So the exception handling is not needed.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
<https://reviews.apache.org/r/28753/#comment106440>
This can now be removed since bootstrapping inserts a RepositoryVersion, e.g., stack is HDP-2.2 and version is 2.2
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
<https://reviews.apache.org/r/28753/#comment106434>
The initial state should instead be UPGRADING.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
<https://reviews.apache.org/r/28753/#comment106443>
The initial state should be UPGRADING since a stack version cannot jump directly into INSTALLED.
If the UI is using INSTALLED as a way to create dummy data, I suggest folks insert the data manually through the DB so that this code can lock-down.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
<https://reviews.apache.org/r/28753/#comment106435>
Not needed any longer.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
<https://reviews.apache.org/r/28753/#comment106444>
Can now remove the exception handling.
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
<https://reviews.apache.org/r/28753/#comment106460>
Again, INSTALLED should not be an acceptable start state.
- Alejandro Fernandez
On Dec. 5, 2014, 5:35 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28753/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 5:35 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8549
> https://issues.apache.org/jira/browse/AMBARI-8549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
>
> Diff: https://reviews.apache.org/r/28753/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.225s]
> [INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.468s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:40.036s
> [INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
> [INFO] Final Memory: 33M/323M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/#review64262
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 8, 2014, 6:11 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28753/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 6:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8549
> https://issues.apache.org/jira/browse/AMBARI-8549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
>
> Diff: https://reviews.apache.org/r/28753/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.225s]
> [INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.468s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:40.036s
> [INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
> [INFO] Final Memory: 33M/323M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/#review64263
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Dec. 8, 2014, 6:11 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28753/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 6:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-8549
> https://issues.apache.org/jira/browse/AMBARI-8549
>
>
> Repository: ambari
>
>
> Description
> -------
>
> for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
>
> Diff: https://reviews.apache.org/r/28753/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.225s]
> [INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.468s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:40.036s
> [INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
> [INFO] Final Memory: 33M/323M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/
-----------------------------------------------------------
(Updated Dec. 8, 2014, 6:11 p.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Changes
-------
Attached updated patch.
Alejandro, I've verified the latest trunk build, and repo version you mentioned is present.
Removed exception handling that is not needed anymore.
Bugs: AMBARI-8549
https://issues.apache.org/jira/browse/AMBARI-8549
Repository: ambari
Description
-------
for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
Diff: https://reviews.apache.org/r/28753/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.225s]
[INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
[INFO] Ambari Agent ...................................... SUCCESS [8.468s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:40.036s
[INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
[INFO] Final Memory: 33M/323M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 5:35 p.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Changes
-------
Fixed unit tests and tested manually.
Also, included parts of another my patch. Now ClusterStackVersions/HostsStackVersions are persisted in INSTALLED state upon creation. That should allow UI team to implement end to end workflow.I'll fix INSTALLED states to INIT states when patch for 2-stage API for distribute repositories/install packages action is ready.
Bugs: AMBARI-8549
https://issues.apache.org/jira/browse/AMBARI-8549
Repository: ambari
Description
-------
for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 125b71b
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 5a9731a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 0e8269f
Diff: https://reviews.apache.org/r/28753/diff/
Testing (updated)
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.225s]
[INFO] Ambari Server ..................................... SUCCESS [27:27.658s]
[INFO] Ambari Agent ...................................... SUCCESS [8.468s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:40.036s
[INFO] Finished at: Fri Dec 05 20:29:41 FET 2014
[INFO] Final Memory: 33M/323M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 28753: Rolling Upgrade: ClusterStackVersion should
display only one repository version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28753/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 3:18 p.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Changes
-------
Previous patch did not work for /stacks endpoint. That's why using another approach
Bugs: AMBARI-8549
https://issues.apache.org/jira/browse/AMBARI-8549
Repository: ambari
Description
-------
for now cluster stack version resource contains all created repository versions: (repo version filtering does not work correctly)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java 97d3bde
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java a12bd29
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 1b3eef8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java c031ac1
Diff: https://reviews.apache.org/r/28753/diff/
Testing
-------
Manual testing.
Patch still is under development
Thanks,
Dmitro Lisnichenko