You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/16 13:29:11 UTC

[GitHub] [skywalking-banyandb] wu-sheng commented on a diff in pull request #118: Fix timeRange check

wu-sheng commented on code in PR #118:
URL: https://github.com/apache/skywalking-banyandb/pull/118#discussion_r873727477


##########
banyand/liaison/grpc/stream.go:
##########
@@ -73,15 +73,14 @@ func (s *streamService) Write(stream streamv1.StreamService_WriteServer) error {
 }
 
 func (s *streamService) Query(_ context.Context, entityCriteria *streamv1.QueryRequest) (*streamv1.QueryResponse, error) {
-	timeRange := entityCriteria.GetTimeRange()
-	if timeRange == nil {
+	if timeRange := entityCriteria.GetTimeRange(); timeRange == nil {
 		entityCriteria.TimeRange = &modelv1.TimeRange{
 			Begin: timestamppb.New(time.Unix(0, 0)),
 			End:   timestamppb.New(time.Unix(0, timestamp.MaxNanoTime)),

Review Comment:
   Relative to the last PR, what does this time range mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org