You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/18 18:42:23 UTC
[GitHub] [airflow] potiuk opened a new pull request, #23782: Further speed up fixing ownership in CI
potiuk opened a new pull request, #23782:
URL: https://github.com/apache/airflow/pull/23782
After #23775 I noticed that there is yet another small improvement
area in the CI buld speed. Currently build-ci-image builds and push
only "commit-tagged" images, but "fix-ownership" requires
the "latest" image to run. This PR adds --tag-as-latest option also
to build-image and build-prod-image commands - similarly as for the
pull-image and pull-prod-image. This will retag the "commit" images
as latest in the build-ci-images step and allow to save 1m on
pulling the latest image before fix-ownership (bringing it back
to 1s overhead)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23782: Further speed up fixing ownership in CI
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23782:
URL: https://github.com/apache/airflow/pull/23782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23782: Further speed up fixing ownership in CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23782:
URL: https://github.com/apache/airflow/pull/23782#issuecomment-1131656716
OK. Besides random failures it also succeedded in main test here: https://github.com/potiuk/airflow/runs/6498123876?check_suite_focus=true with 2 seconds instead of 1 minute overhead for fix-ownership
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23782: Further speed up fixing ownership in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23782:
URL: https://github.com/apache/airflow/pull/23782#issuecomment-1131807547
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org