You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/27 03:09:23 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39227: [SPARK-41722][CONNECT][PYTHON] Implement 3 missing time window functions
zhengruifeng opened a new pull request, #39227:
URL: https://github.com/apache/spark/pull/39227
### What changes were proposed in this pull request?
Implement 3 missing time window functions
### Why are the changes needed?
For API coverage
after this PR, following ones are missing:
1, `call_udf`
2, `pandas_udf`
3, `sequence`
4, `format_number` - SPARK-41473
5, `unwrap_udt`
6, `udf`
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39227: [SPARK-41722][CONNECT][PYTHON] Implement 3 missing time window functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39227:
URL: https://github.com/apache/spark/pull/39227#discussion_r1057415979
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -691,6 +691,46 @@ class SparkConnectPlanner(session: SparkSession) {
}
Some(NthValue(children(0), children(1), ignoreNulls))
+ case "window" if 2 <= fun.getArgumentsCount && fun.getArgumentsCount <= 4 =>
Review Comment:
TimeWindow and SessionWindow do not have suitable constructor for the string parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #39227: [SPARK-41722][CONNECT][PYTHON] Implement 3 missing time window functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39227: [SPARK-41722][CONNECT][PYTHON] Implement 3 missing time window functions
URL: https://github.com/apache/spark/pull/39227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39227: [SPARK-41722][CONNECT][PYTHON] Implement 3 missing time window functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39227:
URL: https://github.com/apache/spark/pull/39227#issuecomment-1365612828
merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39227: [SPARK-41722][CONNECT][PYTHON] Implement 3 missing time window functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39227:
URL: https://github.com/apache/spark/pull/39227#issuecomment-1365586515
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org