You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/03 10:12:21 UTC
[GitHub] [dolphinscheduler] Yao-MR opened a new pull request #8683: [BUG][PLUG_SQL_TASK]format the outProperty to toUpperCase when get the value from result in the sql task
Yao-MR opened a new pull request #8683:
URL: https://github.com/apache/dolphinscheduler/pull/8683
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
fix bug of #8396
what to do fix the bug
format the outProperty to toUpperCase when get the value from result in the sql task
## Brief change log
format the outProperty to toUpperCase when get the value from result in the sql task
## Verify this pull request
This pull request is code cleanup without any test coverage.
This pull request is already covered by existing tests, such as *(please describe tests)*.
This change added tests and can be verified as follows:
<!--*
format the outProperty to toUpperCase when get the value from result in the sql task
* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zwZjut commented on a change in pull request #8683: [BUG][PLUG_SQL_TASK]format the outProperty to toUpperCase when get the value from result in the sql task
Posted by GitBox <gi...@apache.org>.
zwZjut commented on a change in pull request #8683:
URL: https://github.com/apache/dolphinscheduler/pull/8683#discussion_r819325080
##########
File path: dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlParameters.java
##########
@@ -266,7 +266,7 @@ public void dealOutParam(String result) {
//result only one line
Map<String, String> firstRow = sqlResult.get(0);
for (Property info : outProperty) {
- info.setValue(String.valueOf(firstRow.get(info.getProp())));
+ info.setValue(String.valueOf(firstRow.get(info.getProp().toUpperCase())));
Review comment:
what about the situtation
//if sql return more than one line ?
do you know where is the col name of result set to UpperCase , is the loggic right? if user need result of col a, we change it to col A, that is weired. for example, select col_a from table_x, I think we need return col_a instead of COL_A, where the logic of col_a to COL_A should be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Yao-MR commented on pull request #8683: [BUG][PLUG_SQL_TASK]format the outProperty to toUpperCase when get the value from result in the sql task
Posted by GitBox <gi...@apache.org>.
Yao-MR commented on pull request #8683:
URL: https://github.com/apache/dolphinscheduler/pull/8683#issuecomment-1057890455
hi @calvinjiang can you help review this pr, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] gaojun2048 commented on pull request #8683: [BUG][PLUG_SQL_TASK]format the outProperty to toUpperCase when get the value from result in the sql task
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on pull request #8683:
URL: https://github.com/apache/dolphinscheduler/pull/8683#issuecomment-1073183618
It seems that some databases automatically display column names in uppercase. But in DolphinScheduler we don't know when should it be uppercase or not. So DS only keep the column name actual. If user know the column name will automatically display in uppercase, they can use the upppercase column name as the parameter name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #8683: [BUG][PLUG_SQL_TASK]format the outProperty to toUpperCase when get the value from result in the sql task
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8683:
URL: https://github.com/apache/dolphinscheduler/pull/8683#issuecomment-1057902131
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8683?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8683](https://codecov.io/gh/apache/dolphinscheduler/pull/8683?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af08cf4) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/aac960d3d2c7398125e12068bdedb298af280088?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aac960d) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head af08cf4 differs from pull request most recent head 5d44b36. Consider uploading reports for the commit 5d44b36 to get more accurate results
[](https://codecov.io/gh/apache/dolphinscheduler/pull/8683?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #8683 +/- ##
=========================================
Coverage 45.30% 45.30%
Complexity 4073 4073
=========================================
Files 700 700
Lines 27045 27045
Branches 2894 2894
=========================================
Hits 12252 12252
Misses 13639 13639
Partials 1154 1154
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8683?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8683?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c2650ef...5d44b36](https://codecov.io/gh/apache/dolphinscheduler/pull/8683?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #8683: [BUG][PLUG_SQL_TASK]format the outProperty to toUpperCase when get the value from result in the sql task
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #8683:
URL: https://github.com/apache/dolphinscheduler/pull/8683#issuecomment-1057909512
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8683&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8683&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8683&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8683&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8683&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org