[GitHub] [zookeeper] eolivelli commented on a change in pull request #1138: ZOOKEEPER-3546 - Allow optional deletion of never used Container Nodes

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1138: ZOOKEEPER-3546 - Allow optional deletion of never used Container Nodes
URL: https://github.com/apache/zookeeper/pull/1138#discussion_r348196962
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java
 ##########
 @@ -163,7 +163,9 @@ public void runFromConfig(ServerConfig config) throws IOException, AdminServerEx
                 zkServer.getZKDatabase(),
                 zkServer.firstProcessor,
                 Integer.getInteger("znode.container.checkIntervalMs", (int) TimeUnit.MINUTES.toMillis(1)),
-                Integer.getInteger("znode.container.maxPerMinute", 10000));
+                Integer.getInteger("znode.container.maxPerMinute", 10000),
+                Long.getLong("znode.container.maxNeverUsedIntervalMs", Long.MAX_VALUE)
 
 Review comment:
   what about using zero a value for 'disabled'?
   It is very common to use zero as special value in order to 'not enable' features
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services