You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/08 03:31:36 UTC

[GitHub] [apisix] spacewander opened a new pull request #2990: fix: avoid unnecessary type check and support var in local_conf

spacewander opened a new pull request #2990:
URL: https://github.com/apache/apisix/pull/2990


   Also merge bundle of repeated code.
   
   Signed-off-by: spacewander <sp...@gmail.com>
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2990: fix: avoid unnecessary type check and support var in local_conf

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2990:
URL: https://github.com/apache/apisix/pull/2990#issuecomment-741578950


   wow, @spacewander you need to process the conflict first ^_^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming merged pull request #2990: fix: avoid unnecessary type check and support var in local_conf

Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2990:
URL: https://github.com/apache/apisix/pull/2990


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org