[jira] [Created] (TS-2808) Remove the deprecated TSVConnCreate API

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

Leif Hedstrom created TS-2808:
---------------------------------

             Summary: Remove the deprecated TSVConnCreate API
                 Key: TS-2808
                 URL: https://issues.apache.org/jira/browse/TS-2808
             Project: Traffic Server
          Issue Type: Improvement
          Components: TS API
            Reporter: Leif Hedstrom


There seems to be no use of this API, no documentations, and the code seems to imply (as pointed out by Peach), that it can never work. We should nuke it for v5.0.0.

{code}
/* Deprectated.
   Do not use this API.
   The reason is even if VConn is created using this API, it is still useless.
   For example, if we do TSVConnRead, the read operation returns read_vio, if
   we do TSVIOReenable (read_vio), it actually calls:
   void VIO::reenable()
   {
       if (vc_server) vc_server->reenable(this);
   }
   vc_server->reenable calls:
   VConnection::reenable(VIO)

   this function is virtual in VConnection.h. It is defined separately for
   UnixNet, NTNet and CacheVConnection.

   Thus, unless VConn is either NetVConnection or CacheVConnection, it can't
   be instantiated for functions like reenable.

   Meanwhile, this function has never been used.
   */
TSVConn
TSVConnCreate(TSEventFunc event_funcp, TSMutex mutexp)
{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)