[jira] [Resolved] (OAK-6151) Minor bugs in AccessControlImporter

["angela (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved OAK-6151.
-------------------------
    Resolution: Fixed

Committed revision 1793516.

[~tripod], it might be that the fix replacing {{java.security.AccessControlException}} by {{javax.jcr.security.AccessControlException}} has an impact on the ac-import part of Jackrabbit FileVault.

> Minor bugs in AccessControlImporter
> -----------------------------------
>
>                 Key: OAK-6151
>                 URL: https://issues.apache.org/jira/browse/OAK-6151
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>
> while working on OAK-5882 (i.e. writing tests for {{AccessControlImporter}}) i noticed a few minor bugs:
> - {{init}}: should check for {{Session}} implementing {{JackrabbitSession}}
> - {{MutableEntry.setPrincipal}}: for consistency with the rest of the ac-mgt code this should throw {{javax.jcr.security.AccessControlException}} instead of {{java.security.AccessControlException}}
> - {{MutableEntry}}: potential NPE for privileges in case of an incomplete ACE. should create a empty list right away and then leave the handling of the empty priv-array to the {{acl.addEntry}} call in {{applyTo}}, which by default with throw {{AccessControlException}}.
> [~alexparvulescu], fyi



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)