You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Jesus Camacho Rodriguez (JIRA)" <ji...@apache.org> on 2018/11/14 21:44:00 UTC

[jira] [Updated] (CALCITE-2673) Default implementation of SqlDialect should not support pushing all functions

     [ https://issues.apache.org/jira/browse/CALCITE-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesus Camacho Rodriguez updated CALCITE-2673:
---------------------------------------------
    Summary: Default implementation of SqlDialect should not support pushing all functions  (was: SqlDialect supports pushing of all functions by default)

> Default implementation of SqlDialect should not support pushing all functions
> -----------------------------------------------------------------------------
>
>                 Key: CALCITE-2673
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2673
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>             Fix For: 1.18.0
>
>
> SqlDialect contains a 'supportsFunction' that can be used by rules to know whether a certain function is supported in the given dialect, e.g., to choose whether to push a Filter expression to JDBC, etc.
> The default implementation of 'supportsFunction' always returns true.
> I believe a better idea would be to support in the default implementation for the method the most common SQL functions. Then each dialect can override that behavior and expand/limit the supported functions, e.g., JethroDataDialect already does that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)