You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/05/10 21:25:58 UTC

[GitHub] [couchdb] nickva commented on pull request #3402: Add new endpoint _fdb_up to liveness and readiness probe checks

nickva commented on pull request #3402:
URL: https://github.com/apache/couchdb/pull/3402#issuecomment-837370769


   @tonysun83 reminded me that `_up` endpoint already checks FDB connectivity:
   
   https://github.com/apache/couchdb/blob/main/src/chttpd/src/chttpd_misc.erl#L368
   
   However, we may want to add a minor improvement where we don't let the `_up` request directly go to the FDB backend as we might not want unauthenticated requests to necessarily start read transactions. We could, for example have the `fabric2_server` periodically make that `list_dbs` call (or simply just get the metadata version) and update a fabric app environment variable or put it in some ETS table then the `_up` endpoint would only read from there and return. It might also let us define exactly what the node (pods, containers?) would do when FDB becomes unavailable for a while - keep trying to maybe stop the VM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org