You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/09/02 07:06:01 UTC

[GitHub] [avro] clesaec commented on a diff in pull request #1842: AVRO-3618: Test both directBinaryDecoder and binaryDecoder

clesaec commented on code in PR #1842:
URL: https://github.com/apache/avro/pull/1842#discussion_r961354244


##########
lang/java/avro/src/test/java/org/apache/avro/io/TestBinaryDecoder.java:
##########
@@ -317,7 +320,7 @@ private void validateInputStreamSkips(InputStream test, InputStream check) throw
   public void testBadIntEncoding() throws IOException {
     byte[] badint = new byte[5];
     Arrays.fill(badint, (byte) 0xff);
-    Decoder bd = factory.binaryDecoder(badint, null);
+    Decoder bd = this.newDecoder(badint);

Review Comment:
   Change, all methods now test DirectBinaryDecoder, then BinaryDecoder. We can see that the behavior sometimes differs  with the type of exceptions that are thrown. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org