[GitHub] [ignite-3] isapego commented on a diff in pull request #956: IGNITE-17135 Fix inconsistent SQL exceptions on server and client

[GitBox <gi...@apache.org>]

isapego commented on code in PR #956:
URL: https://github.com/apache/ignite-3/pull/956#discussion_r930423304


##########
modules/api/src/main/java/org/apache/ignite/internal/sql/ResultSetImpl.java:
##########
@@ -83,7 +85,7 @@ public void close() {
     @Override
     public boolean hasNext() {
         if (it == null) {
-            throw new SqlException("There are no results");
+            throw new SqlException(QUERY_NO_RESULT_SET_ERR, "There are no results");

Review Comment:
   This is mostly a question to SQL guys, but are we sure we want to throw exception in this case at all? Why won't we just return `false`? How throwing an exception can be helpful for a user in this case? What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org