You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/13 14:53:39 UTC

[GitHub] [iotdb] samperson1997 commented on a change in pull request #2992: [To Vector] Fix Tablet.addValue()

samperson1997 commented on a change in pull request #2992:
URL: https://github.com/apache/iotdb/pull/2992#discussion_r612522499



##########
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##########
@@ -1541,7 +1541,7 @@ protected void sortTablet(Tablet tablet) {
         int measurementSize = schema.getValueMeasurementIdList().size();
         for (int j = 0; j < measurementSize; j++) {
           tablet.values[columnIndex] =
-              sortList(tablet.values[columnIndex], schema.getValueTSDataTypeList().get(i), index);
+              sortList(tablet.values[columnIndex], schema.getValueTSDataTypeList().get(j), index);

Review comment:
       Added. Also add a complicated test case for mix MeasurementSchema and VectorMeasurementSchema in the same tablet : )




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org