You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Marcell Szabo (Code Review)" <ge...@cloudera.org> on 2016/04/20 14:30:48 UTC
[Impala-CR](cdh5-trunk) IMPALA-3382: Long warnings cause impala-shell to stall
Marcell Szabo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/2821
Change subject: IMPALA-3382: Long warnings cause impala-shell to stall
......................................................................
IMPALA-3382: Long warnings cause impala-shell to stall
Change-Id: I5d4ea7fc3e82f11151c170a9835ca9fcbbb3a94a
---
M shell/impala_client.py
M shell/impala_shell.py
M shell/option_parser.py
3 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/21/2821/1
--
To view, visit http://gerrit.cloudera.org:8080/2821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d4ea7fc3e82f11151c170a9835ca9fcbbb3a94a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <sz...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3382: Long warnings cause impala-shell to stall
Posted by "Juan Yu (Code Review)" <ge...@cloudera.org>.
Juan Yu has posted comments on this change.
Change subject: IMPALA-3382: Long warnings cause impala-shell to stall
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/2821/1//COMMIT_MSG
Commit Message:
Line 7: stall
stale?
Could you add some explanation about why the long warning cause shell to stale?
http://gerrit.cloudera.org:8080/#/c/2821/1/shell/impala_client.py
File shell/impala_client.py:
Line 459: 10000
use a constant for this
Line 460: return "WARNINGS: %s \n(truncated, please use --display_full_warning to display more)" % log[0:10000]
long line
http://gerrit.cloudera.org:8080/#/c/2821/1/shell/option_parser.py
File shell/option_parser.py:
Line 111: store_true
We want the option default to false? right?
--
To view, visit http://gerrit.cloudera.org:8080/2821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d4ea7fc3e82f11151c170a9835ca9fcbbb3a94a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <sz...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3382: Long warnings cause impala-shell to stall
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has abandoned this change.
Change subject: IMPALA-3382: Long warnings cause impala-shell to stall
......................................................................
Abandoned
IMPALA-3859 made this unneeded.
--
To view, visit http://gerrit.cloudera.org:8080/2821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5d4ea7fc3e82f11151c170a9835ca9fcbbb3a94a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <sz...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3382: Long warnings cause impala-shell to stall
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3382: Long warnings cause impala-shell to stall
......................................................................
Patch Set 1:
Please update to using the new gerrit project, "Impala-ASF".
Instructions are here:
https://cwiki.apache.org/confluence/display/IMPALA/How+to+switch+to+Apache-hosted+git
Pushes to this project will be disabled on October 1.
--
To view, visit http://gerrit.cloudera.org:8080/2821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d4ea7fc3e82f11151c170a9835ca9fcbbb3a94a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <sz...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3382: Long warnings cause impala-shell to stall
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3382: Long warnings cause impala-shell to stall
......................................................................
Patch Set 1:
Marcell, is this something you will move forward or should it be abandoned?
--
To view, visit http://gerrit.cloudera.org:8080/2821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d4ea7fc3e82f11151c170a9835ca9fcbbb3a94a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <sz...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-HasComments: No